Apologies if i'm not following the conversation correctly, but i feel it
would be preferable to make 'open on rollover' optional, and switched
off by default. This way it won't impact on existing desktop apps that
have been using it - like mine ;)
On 16/10/2013 17:53, Alex Harui wrote:
Honestly, I don't have an opinion. And as long as we keep making release
every 2 or 3 months, it doesn't really matter. That's Apache Way: do
something, gather feedback, make changes.
I will say that it sounds like there is lots of complexity around using
rollOver as a trigger and maybe even needing to decide on a "dismissEvent"
as well, so I'm glad it isn't me doing the work.
-Alex
On 10/16/13 9:48 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
wrote:
BTW, do you think it should be implemented as a binary option (ie
triggerEvent=rollover / click ] or rather as a style "rollOverOpenDelay"
(cf. VolumeBar).
The use case for this is that for "heavy" rollover callouts, developer
might want to increase the rollover delay , whereas for small
lightweight callouts, rollOverOpenDelay could be set to a small value for
better responsiveness.
WDYT?
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : mercredi 16 octobre 2013 18:41
À : dev@flex.apache.org
Objet : RE: [Mustella] tests/experimental/spark/components/CallOutButton
If you've got the time, go for it.
I will try to this WE.
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 16 octobre
2013 18:37 À : dev@flex.apache.org Objet : Re: [Mustella]
tests/experimental/spark/components/CallOutButton
If you've got the time, go for it.
On 10/16/13 9:33 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
wrote:
I checked the code of experimental CallOut in SDK 4.10:
[Inspectable(category="General", enumeration="rollOver,click",
defaultValue="rollOver")] //mouseOver public var triggerEvent:String =
MouseEvent.ROLL_OVER;
So this option has been lost after the merge, as it does not exist in
the common CalloutButton class.
Which means the default behavior of desktop callout is actually changed.
Maybe we should add it in the new merged CalloutButton, as it seems to
be rather useful.
But in this case, this option should be excluded on mobile devices (or
at least disable, if not possible ).
WDYT?
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : mercredi 16 octobre 2013 18:19 À : dev@flex.apache.org Objet :
RE: [Mustella] tests/experimental/spark/components/CallOutButton
I didn't know about this MetaData.
The original CalloutButton does not have it: by default, you must click
to make the callout appear.
You can simulate this behavior with this trick:
<s:CalloutButton id="calloutButtonBasic" label="button"
horizontalCenter="0" verticalCenter="0"
rollOver="calloutButtonBasic.openDropDown()"
rollOut="calloutButtonBasic.closeDropDown()" >
WDYT?
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 16 octobre
2013 18:13 À : dev@flex.apache.org Objet : Re: [Mustella]
tests/experimental/spark/components/CallOutButton
It appears that CallOutButton had a "triggerEvent" in its metadata so
the MXML could look like <ns:CallOutButton triggerEvent="rollOver" />
On 10/16/13 8:57 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
wrote:
Do you mean, the "rollover" event that is in CallouButton_Basic.mxml
test cases, does not trigger for CalloutButton ?
-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 16 octobre
2013 17:34 À : dev@flex.apache.org Objet : Re: [Mustella]
tests/experimental/spark/components/CallOutButton
I tried fixing those tests, but they seem to use a triggerEvent which
I didn't see on CalloutButton. Do you know what the equivalent would
be?
-Alex
On 10/16/13 8:01 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
wrote:
There are tests on CalloutButton, and "indirect" tests of Callout in
SplitViewNavigator, but they are all in the mobile area.
I think we should create Callout / CalloutButton tests in the
gumbo/components directory as well, and remove the experimental tests.
Or maybe just move the experimental tests into gumbo, renaming
CallOutButton to CalloutButton and recreating the baseline pngs.
WDYT?
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 16
octobre
2013 16:55 À : dev@flex.apache.org Objet : Re: [Mustella]
tests/experimental/spark/components/CallOutButton
Are there tests for Callout and CalloutButton already? If so, then
these experimental tests can be removed.
-Alex
On 10/16/13 7:48 AM, "Maurice Amsellem" <maurice.amsel...@systar.com>
wrote:
CallOutButton and CallOut classes do not exist anymore.
They have been merged with Callout and CalloutButton, using spark
skins.
So IMO, the tests should be removed, or at least replaced by tests
on Callout / CalloutButton using the spark skins instead of the
mobile skins.
WDYT?
Maurice
-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 16
octobre
2013 16:43 À : dev@flex.apache.org Objet : [Mustella]
tests/experimental/spark/components/CallOutButton
These tests do not compile for me. Do they work for anyone else?
I can't find where they are excluded.
-Alex
--
Lee Burrows
ActionScripter