What do you think for the conditional compilation, we add a new defined constant based on "os family" in Ant and use it in the code to use / compile classes or you see something else ?
I just created the branch, will commit it. -Fred -----Message d'origine----- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : dimanche 29 septembre 2013 22:16 À : dev@flex.apache.org Objet : RE: [Intaller] Speed up download > The good thing is that Installer.mxml is a whole bunch of small > methods instead of long methods. It should be easier than you think to make them more organized into classes. I stopped my try of splitting the first step today when I hit the hidden text field but yes, it is easily manageable if the whole class is rethought. I've got a nice class for locales [1] as well if needed. -Fred [1] https://github.com/apacheflex/whiteboard_fthomas_developerToolSuite/blob/dev elop/org.apache.flex.utilities.developerToolSuite.locale/src/main/flex/org/a pache/flex/utilities/developerToolSuite/LocaleUtil.as -----Message d'origine----- De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de OmPrakash Muppirala Envoyé : dimanche 29 septembre 2013 21:55 À : dev@flex.apache.org Objet : RE: [Intaller] Speed up download On Sep 29, 2013 12:25 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > > It is a very long run though for only one coder, I'm on 2 other > projects out > of my work and here, I would hope it can be done on a parallel branch > and not by only one coder. > > But, yes, I think the Installer has become large enough to be rethought. > > I very well know parsley as MVC framework and even though I worked > with others, none of them convinced me as much as this one, the bad > point is it is not on known maven repositories and even less for the > last version from what I know (except on my own repo), so, it would > mean we continue with Ant > and download the artifacts thru it. > > The good point using this MVC/IOC framework is I've already got the > code for > few things. > > Any thoughts on that first ? Parsley is fine with me. And yes, we can download it via ant like we do for the as3commons library. The good thing is that Installer.mxml is a whole bunch of small methods instead of long methods. It should be easier than you think to make them more organized into classes. > > -Fred > > -----Message d'origine----- > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > OmPrakash Muppirala Envoyé : dimanche 29 septembre 2013 20:54 À : > dev@flex.apache.org Objet : Re: [Intaller] Speed up download > > On Sun, Sep 29, 2013 at 11:48 AM, Frédéric THOMAS > <webdoubl...@hotmail.com>wrote: > > > Actually I tried to split it today but it is a kind of impossible > > mission without a complete architecture review, I mean without > > introducing the MVC pattern, but it would mean a ton of work. > > > > > I think we should go ahead and do it. The Installer started out as a simple > UI for a command line script. It became so big so quickly that the > main app > is a couple of thousand lines long. I vote for refactoring before we > add more features. > > We might also want to think of things like Linux support (conditional > compliation, etc.), Falcon, FlexJS, etc. support as we go forward. > > Would you be willing to take charge? I will help as much as I can. > > Thanks, > Om > > > > So, I've got the parallel downloads working and that's on my github > > but won't try to integrate it at the moment. > > What I will try to do, is integrate the maven options, without using > > any cache though at the moment. > > > > -Fred > > > > [1] https://github.com/doublefx/downloadFileWorker > > > > -----Message d'origine----- > > De : Tom Chiverton [mailto:t...@extravision.com] Envoyé : lundi 16 > > septembre 2013 18:11 À : dev@flex.apache.org Objet : Re: [Intaller] > > Speed up download > > > > On 16/09/2013 16:10, Frédéric THOMAS wrote: > > > The thing that scare me though is the InstallApacheFlex.mxml is > > > more than > > > 2200 lines long > > Number one job might be to sort that out then... :-) > > > > Tom > >
