-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] 
Envoyé : jeudi 26 septembre 2013 18:58
À : dev@flex.apache.org
Objet : RE: Building the SDK from git

Hi, 

This is my (uncensored :-) feedback following the SDK build.

1) Doc inconsistency: 
There are 3 differents docs explaining how to build the SDK:
 - WIKI:
https://cwiki.apache.org/confluence/display/FLEX/1.2+Setting+up+Manually
- WEB: http://flex.apache.org/dev-sourcecode.html
- README file in sdk root.

Which contain the potentially inconsistent information:
a) README says JAVA 1.6 minimum is required , whereas WIKI only states
"download java".  I was using JDK 1.5 and got into an issue when building
the "modules" (target 1.6 not valid).
=> I think the wiki shoul also mention 1.6 minimum requirement

b) git commands to retrieve the repos:
- README says git clone https://git-wip-us.apache.org/repos/asf/flex-sdk.git
sdk
- WEB says same as README
- WIKI says git clone [https://git-wip-us.apache.org/repos/asf/flex-sdk.git]
flex-sdk


True, it is inconsistent but both work.


Note: actually, maybe 3 sources of information on how to build the SDK are
just too much.
Maybe only the WIKI should be kept, and the README just provide a link to
the wiki.
That would make maintenance easier.

2) When launching the build for the first time, it fails because the
"modules"  (FlexTasks, mxmlc, etc..) are not built yet.
=> either mention in the doc that modules needs to be built before hand =>
or better, add a dependency in the main build so that it's done
automatically , if not present.

ant thirdparty-downloads should be enough to run once only, you can then run
the other targets, I never had to run explicitly any builds from the
modules.



3) missing values:
TLF_HOME is missing from env-template.properties

True but  it is not mandatory ant  still mentioned in the readme


4)  build.properties not up to date
=> fixed

5) .actionScriptProperties and .flexLibProperties are missing from
.gitignore => controversial.


Some of those files are in the repo already, so, it can be added to the main
.gitignore only if we add .gitignore files in the folders where they stand,
why not.


6) Fred told me I should set " core.autocrlf" to "input" to avoid issues
when committing from Windows.
=> I think this should be set per-repository in the .gitattributes of
flex-sdk and flex-tlf, so that everyone has the same settings, and we don't
have to bother about that anymore.

The default for windows seems to be "true" and "input" for other OSes but
because I run the Ant tasks from Cygwin, I had to set it to "input" for not
having build issues.


7) Fred says I need to run "ant other.locales" to avoid trouble in French
env.  
This is not mentioned anywhere in the doc.
=> Add to the WIKI.

Or you can run ant -Dlocale=fr_FR only to go faster and it is mention in the
readme.


Regards,

Maurice 

-----Message d'origine-----
De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 26 septembre 2013
18:32 À : dev@flex.apache.org Objet : Re: Building the SDK from git



On 9/26/13 9:12 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote:

>BUILD SUCCESSFUL!
>
>YEEHAA!
>
>Do you me to recap the few issues I have faced as a "newbie"?
Sure.  I think you'll be getting write access soon, so then you'll be able
to update the README yourself.

-Alex

Reply via email to