Thank you Alex. The instructions are clear.
I will prepare the files for check-in (adding headers and notice). I have some more questions regarding the integration: 1) Should I also move the files to different packages (eg. spark.components in experimental) 2) should I rename the classes to comply with the rest of the source code (eg. MobileDataGrid to DataGrid). 3) Should I add ASDOC comments on the public API, or at least a small comment on each class describing its purpose? 4) I had to monkey-patch ItemLabelRenderer to make some variables protected, and abstract it (ie remove the default label and labelDisplay) so that I it becomes "empty" base class for my renderers (typically ListMultiPartItemRenderer). To avoid code duplication, would it be possible to make some "neutral" changes in ItemLabelRenderer, or even split it into ItemRendererBase (no label) and ItemLabelRenderer. 5) more questions to go... Should I ask these questions here on the dev list, or by direct mail to one of the PPMC? Regards, Maurice -----Message d'origine----- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mercredi 25 septembre 2013 17:46 À : dev@flex.apache.org Objet : Re: Flex Mobile DataGrid donation submission On 9/25/13 8:07 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote: >Hi, > >I just sent by email the three required documents, filled and signed, >to secret...@apache.org. > >Should I receive an acknowledgement? If you put yourself down as the contact on the Software Grant you should receive an email back when it is recorded. I'll keep an eye out as well. Sometimes it happens same day, usually the next day, sometimes it takes longer. >What are the next steps? I started a vote just so folks who don't follow all emails are notified. I can't imagine any objections, so IMO, this is mostly a formality. There is a non-public process going on that is required to get you write access to the repo. That can take a few days. One of us will notify you when that's happened. Meanwhile, after the software grant is also recorded, please make a snapshot of the code available somehow. It should be your best attempt at making it ready for public consumption, so it should have headers, preferably, the Apache headers with a NOTICE file containing the Systar copyright. The code will be reviewed by some member of the Apache Flex PMC (I'm guessing it will be me, although I'm in the middle of another IP clearance, but on hold waiting for an answer). Then once the code is cleared and you have write access you can check it in. I may ask you to make further adjustments post-checkin. Thank you and Systar again for the donation, -Alex
