So you'd like me to change the isCellEditable to [1] or you mean on whats
calling the isCellEditable in the first place (startItemEditorSession)?
[1]
protected function isCellEditable(rowIndex:int, columnIndex:int):Boolean
{
try
{
var dataItem:Object = dataProvider.getItemAt(rowIndex);
var column:GridColumn =
GridColumn(columns.getItemAt(columnIndex));
var dataField:String = column.dataField;
}
catch (e)
{
return false;
}
return isDataEditable(dataItem, dataField);
}
What drew me into it was the fact the failing Mustella test has two asserts
that are purposefully out of range it looks like. They are using the
lengths instead of the (-1) last index.
gumbo\components\DataGrid\Properties\DataGrid_Properties_editable.mxml
Editable_startItemEditorSesision_inValidParams
<AssertMethodValue
method="value=FlexGlobals.topLevelApplication.dataGrid2.startItemEditorSession(0,FlexGlobals.topLevelApplication.dataGrid2.columns.length)"
value="false"/>
<AssertMethodValue
method="value=FlexGlobals.topLevelApplication.dataGrid2.startItemEditorSession(FlexGlobals.topLevelApplication.dataGrid2.dataProvider.length,FlexGlobals.topLevelApplication.dataGrid2.columns.length)"
value="false"/>
-Mark
On Wed, Sep 4, 2013 at 9:03 PM, Justin Mclean <jus...@classsoftware.com>wrote:
> Hi,
>
> > It made logical sense to me since an out of range cell reference is not
> > editable. I know they liked range errors at Adobe, but do we want to
> keep
> > this behavior ATM? If so I'll revert the change.
>
> I'd go for do a try/catch for a range error and if it occurs return false
> - that's probably less expensive.
>
> Justin
