On 5/28/13 9:13 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> Wouldn't surprise me. Did you check in the new/corrected baseline? >No I assume I just copy the "bad" image over the original one and check >in? The recommended practice is to run that test or the whole script with -createImages, delete the *.png.xml files unless you need them to resolve some cross-platform issue, then run the test or whole script without -createImages to make sure it passes. The reason to use this longer procedure is because, if we do decide someday to use -createImages to generate new baselines for a whole script for some other reason, then you can know that at the time the baseline was taken, the tests did not have some timing issue between -createImages mode and compareBitmap mode. Otherwise, the person trying to recut all of those baselines ends up having to debug any timing issues. That said, I will have no way of knowing whether you used this procedure or not ;-) > >Would you mind double checking the test and confirm that the ADG cell >should all be RTL, I'm fairly certain but wouldn't want to hide the issue >if there something wrong. I looked at the checked-in baseline. It looked right to me, but I can't always do RTL stuff in my head. What does your "new" baseline look like? Maybe send it to me off-list or post a link to it so I can see if yours makes "more sense". > >Thanks, >Justin >
