Sounds reasonable to me. I try to be consistent with it. But I usually use (displayobject) (!displayobject) to test existence of the visible objects and I use (variable ==null) for the rest.
Anywho tiny update for the consistency. On Sun, Apr 28, 2013 at 8:41 AM, Justin Mclean <jus...@classsoftware.com>wrote: > Hi, > > > You were right. I've updated it to test for them. Seems to be good now. > > Not a biggie but try be be consistent with the null checks ie > dataProvider vs values != null. > > Also nothing wrong with doing something like this at the top of the > function. > > if (dataProvider == null || values == null) > return []; > > Thanks, > Justin > > >