Hi Justin, Thanks for grinding through these. But are you saying if I run these tests I will get failures. If so, were these test failing before your change? If you check in with new failures, it just makes more work for everyone else. At minimum, disable the tests and remember to come back and look at them (or file a JIRA to remind us).
Thanks, -Alex On 4/26/13 12:32 AM, "jmcl...@apache.org" <jmcl...@apache.org> wrote: > Added single digit day and month tests. Fixed broken tests (state remembers > date format). Two test currently fail bitmaps as different error is show. Not > clear what order validation errors should show in. > > > Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo > Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/d7c12ee5 > Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/d7c12ee5 > Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/d7c12ee5 > > Branch: refs/heads/develop > Commit: d7c12ee5a241db331ef47182339ac3a95dd29cda > Parents: 9860696 > Author: Justin Mclean <jmcl...@apache.org> > Authored: Fri Apr 26 17:32:16 2013 +1000 > Committer: Justin Mclean <jmcl...@apache.org> > Committed: Fri Apr 26 17:32:16 2013 +1000 > > ---------------------------------------------------------------------- > .../Properties/Validators_Date_Properties.mxml | 3 + > .../Validators_Date_Properties_spark.mxml | 86 ++++++++++++++- > 2 files changed, 86 insertions(+), 3 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d7c12ee5/mustella/tests/V > alidators/DateValidator/Properties/Validators_Date_Properties.mxml > ---------------------------------------------------------------------- > diff --git > a/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s.mxml > b/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s.mxml > index e00298a..1432fb6 100644 > --- > a/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s.mxml > +++ > b/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s.mxml > @@ -125,6 +125,7 @@ > <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > > <SetProperty target="myCustomDt.myDt" propertyName="property" value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="MM-DD-YYYY"/> > <SetProperty target="myCustomDt.ti1" propertyName="text" value="12-31-2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > <WaitForEffectsToEnd /> > </setup> > @@ -141,6 +142,7 @@ > > <SetProperty target="myCustomDt.myDt" propertyName="property" value="text"/> > <SetProperty target="myCustomDt.myDt" propertyName="allowedFormatChars" > value="#"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="MM#DD#YYYY"/> > <SetProperty target="myCustomDt.ti1" propertyName="text" value="12#31#2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > <WaitForEffectsToEnd /> > </setup> > @@ -207,6 +209,7 @@ > > <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > <SetProperty target="myCustomDt.myDt" propertyName="property" value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="MM/DD/YYYY"/> > <SetProperty target="myCustomDt.ti1" propertyName="text" value="31$12/2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > <WaitForEffectsToEnd /> > </setup> > > http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/d7c12ee5/mustella/tests/V > alidators/DateValidator/Properties/Validators_Date_Properties_spark.mxml > ---------------------------------------------------------------------- > diff --git > a/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s_spark.mxml > b/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s_spark.mxml > index 79aec02..997f492 100644 > --- > a/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s_spark.mxml > +++ > b/mustella/tests/Validators/DateValidator/Properties/Validators_Date_Propertie > s_spark.mxml > @@ -99,7 +99,22 @@ > <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > > </body> > - </TestCase> > + </TestCase> > + <TestCase > testID="DateValidator_allowedFormatChars_ForwardSlash_SingleDateAndMonth_spark > " keywords="[DateSymbol, DateValidator]"> > + <setup> > + <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > + <SetProperty target="myCustomDt.myDt" propertyName="property" > value="text"/> > + > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="YYYY/M/D"/> > + </setup> > + <body> > + <SetProperty target="myCustomDt.ti1" propertyName="text" > value="2006/7/17" waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > + <DispatchKeyEvent keys="[TAB, TAB]" /> > + <AssertEvent target="myCustomDt.myDt" eventName="valid" > eventClass="mx.events::ValidationResultEvent" /> > + <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > + > + </body> > + </TestCase> > <TestCase testID="DateValidator_allowedFormatChars_BackwardSlash_spark" > keywords="[DateSymbol, DateValidator]"> > <setup> > <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > @@ -116,6 +131,22 @@ > > </body> > </TestCase> > + <TestCase > testID="DateValidator_allowedFormatChars_SingleDateAndMonth_spark" > keywords="[DateSymbol, DateValidator]"> > + <setup> > + <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > + > + <SetProperty target="myCustomDt.myDt" propertyName="property" > value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="D/M/YYYY"/> > + > + </setup> > + <body> > + <SetProperty target="myCustomDt.ti1" propertyName="text" > valueExpression="value='3\\12\\2006'" waitEvent="updateComplete" > waitTarget="myCustomDt.ti1"/> > + <DispatchKeyEvent keys="[TAB, TAB]" /> > + <AssertEvent target="myCustomDt.myDt" eventName="valid" > eventClass="mx.events::ValidationResultEvent" /> > + <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > + > + </body> > + </TestCase> > <TestCase testID="DateValidator_allowedFormatChars_Hyphen_Invalid_spark" > keywords="[DateSymbol, DateValidator]"> > <setup> > > @@ -131,6 +162,22 @@ > <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > </body> > </TestCase> > + <TestCase > testID="DateValidator_allowedFormatChars_Hyphen_SingleMonthAndDate_spark" > keywords="[DateSymbol, DateValidator]"> > + <setup> > + > + <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > + > + <SetProperty target="myCustomDt.myDt" propertyName="property" > value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="m-d-yyyy"/> > + <SetProperty target="myCustomDt.ti1" propertyName="text" value="1-1-2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > + <WaitForEffectsToEnd /> > + </setup> > + <body> > + <DispatchKeyEvent keys="[TAB, TAB]" /> > + <AssertEvent target="myCustomDt.myDt" eventName="valid" > eventClass="mx.events::ValidationResultEvent" /> > + <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > + </body> > + </TestCase> > <TestCase testID="DateValidator_allowedFormatChars_Hyphen_hash_spark" > keywords="[DateSymbol, DateValidator]"> > <setup> > > @@ -138,6 +185,7 @@ > > <SetProperty target="myCustomDt.myDt" propertyName="property" value="text"/> > <SetProperty target="myCustomDt.myDt" propertyName="allowedFormatChars" > value="#"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="MM#DD#YYYY"/> > <SetProperty target="myCustomDt.ti1" propertyName="text" value="12#31#2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > <WaitForEffectsToEnd /> > </setup> > @@ -163,6 +211,22 @@ > <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > </body> > </TestCase> > + <TestCase testID="DateValidator_inputFormat_d_m_spark" > keywords="[DateSymbol, DateValidator]"> > + <setup> > + > + <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > + > + <SetProperty target="myCustomDt.myDt" propertyName="property" > value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="d/m"/> > + <SetProperty target="myCustomDt.ti1" propertyName="text" value="1/7" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > + <WaitForEffectsToEnd /> > + </setup> > + <body> > + <DispatchKeyEvent keys="[TAB, TAB]" /> > + <AssertEvent target="myCustomDt.myDt" eventName="valid" > eventClass="mx.events::ValidationResultEvent" /> > + <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > + </body> > + </TestCase> > <TestCase testID="DateValidator_inputFormat_dd_mm_spark" > keywords="[DateSymbol, DateValidator]"> > <setup> > > @@ -179,7 +243,22 @@ > <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > </body> > </TestCase> > - > + <TestCase testID="DateValidator_inputFormat_d_m_spark" > keywords="[DateSymbol, DateValidator]"> > + <setup> > + > + <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > + > + <SetProperty target="myCustomDt.myDt" propertyName="property" > value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="D/M"/> > + <SetProperty target="myCustomDt.ti1" propertyName="text" value="31/12" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > + <WaitForEffectsToEnd /> > + </setup> > + <body> > + <DispatchKeyEvent keys="[TAB, TAB]" /> > + <AssertEvent target="myCustomDt.myDt" eventName="valid" > eventClass="mx.events::ValidationResultEvent" /> > + <AssertNoEvent target="myCustomDt.myDt" eventName="invalid" /> > + </body> > + </TestCase> > <TestCase testID="DateValidator_formatError_spark" keywords="[DateSymbol, > DateValidator]"> > <setup> > > @@ -201,6 +280,7 @@ > > <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > <SetProperty target="myCustomDt.myDt" propertyName="property" value="text"/> > + <SetProperty target="myCustomDt.myDt" propertyName="inputFormat" > value="MM/DD/YYYY"/> > <SetProperty target="myCustomDt.ti1" propertyName="text" value="31$12/2006" > waitEvent="updateComplete" waitTarget="myCustomDt.ti1"/> > <WaitForEffectsToEnd /> > </setup> > @@ -263,7 +343,7 @@ > <CompareBitmap target="" > url="../Properties/baselines/wrongYearError_spark.png" timeout="5000" /> > </body> > </TestCase> > - <TestCase testID="DateValidator_dateFormat_spark" keywords="[DateSymbol, > DateValidator]"> > + <TestCase testID="DateValidator_dateFormat_YearDateWrongWayAbout_spark" > keywords="[DateSymbol, DateValidator]"> > <setup> > > <ResetComponent target="myCustomDt" className="CustomDt" > waitEvent="updateComplete" waitTarget="myCustomDt"/> > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
