This is being picky, but you have too much whitespace here:

> +    public function DateFormatter(formatString : String = null)

Should be:
    public function DateFormatter(formatString:String = null)

And not enough here?

> +  this.formatString = formatString;



On 3/22/13 6:47 AM, "cza...@apache.org" <cza...@apache.org> wrote:

> Updated Branches:
>   refs/heads/develop c81ae8cff -> 875a6538f
> 
> 
> FLEX-12628 added formatString to DateFormatter constructor as optional
> argument
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/875a6538
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/875a6538
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/875a6538
> 
> Branch: refs/heads/develop
> Commit: 875a6538fe984c4185b67b25336259ba9e077ebe
> Parents: c81ae8c
> Author: cyrill.zadra <cyrill.za...@gmail.com>
> Authored: Fri Mar 22 23:20:29 2013 +1000
> Committer: cyrill.zadra <cyrill.za...@gmail.com>
> Committed: Fri Mar 22 23:30:22 2013 +1000
> 
> ----------------------------------------------------------------------
>  .../framework/src/mx/formatters/DateFormatter.as   |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/875a6538/frameworks/proje
> cts/framework/src/mx/formatters/DateFormatter.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/framework/src/mx/formatters/DateFormatter.as
> b/frameworks/projects/framework/src/mx/formatters/DateFormatter.as
> index 0bcba11..6937aa5 100644
> --- a/frameworks/projects/framework/src/mx/formatters/DateFormatter.as
> +++ b/frameworks/projects/framework/src/mx/formatters/DateFormatter.as
> @@ -339,16 +339,20 @@ public class DateFormatter extends Formatter
>  
>      /**
>       *  Constructor.
> +
> +    *  @param formatString Date format pattern is set to this DateFormatter.
>       *  
>       *  @langversion 3.0
>       *  @playerversion Flash 9
>       *  @playerversion AIR 1.1
>       *  @productversion Flex 3
>       */
> -    public function DateFormatter()
> +    public function DateFormatter(formatString : String = null)
>      {
>          super();
> -    }
> +
> +  this.formatString = formatString;
> + }
>  
>      
> //--------------------------------------------------------------------------
>      //
> 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Reply via email to