Hi Alex,
For the 2 last fail tests[1], it comes from the PopUpManagerImpl.as changes
I did, the tests are broken but I still thing the fix is good, if I'm not
wrong, the fact is the view bounds taken in account are out of what is
visible, so, the image compare fails because it takes in account the +1
width and height pixels of the new popup blocker size.
It's not obvious to debug mustella, if needed I'll do it but if you can
simply update the PopUpManagerImpl.as to include my fix (line 767:
g.drawRect(screen.x-1, screen.y-1, screen.width+2, screen.height+2);), build
the framework, run mini_run.sh tests/spark/styles/local/ and do an
ImageDiffAir on the 2 bad images, you might be able to determinate in a more
intuitive way than me if we need to simply re-generate those 2 baselines or
try to fix the UnitTester/CompareBitmap classes it takes in account what is
visible only.
[1]
spark/styles/local/dropShadowVisible_css_tester dropShadowVisible_css_Alert
spark/styles/local/dropShadowVisible_tester dropShadowVisible_default_Alert
-Fred
-----Message d'origine-----
From: Frédéric THOMAS
Sent: Friday, February 15, 2013 10:26 AM
To: dev@flex.apache.org
Subject: Re: Apache Flex 4.9.1
Hi,
Just finished to run the test suite against the release4.9, still got:
LangPacks/Japanese/tests/...
components/Charts/Bubble/Properties/BubbleProperties
BubbleSeries_multipleAxes_disabledDays
spark/styles/local/dropShadowVisible_css_tester dropShadowVisible_css_Alert
spark/styles/local/dropShadowVisible_tester dropShadowVisible_default_Alert
I then did an update and tried to run the failed
LangPacks/Japanese/tests/... against your last fix (DroidSansFallback.ttf
and new baselines) but still fail.
For the components/Charts/Bubble IIRC, it didn't fail on your MAC, maybe it
only something about color/pixel tolerance, I'm going to investigate the 2
last.
-Fred
-----Message d'origine-----
From: Alex Harui
Sent: Thursday, February 14, 2013 10:45 PM
To: dev@flex.apache.org
Subject: Re: Apache Flex 4.9.1
On 2/14/13 1:36 PM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote:
Ok, enjoy though :-)
I'm building and running tests on the release4.9 on my side, I'd like to
compare with your results at some point hoping there will not be
differences
and see if I can (not sure) fix things.
I wasn't going to do a full run until tonight. If I'm lucky I will be able
to post results in my morning before the flight. I will try to investigate
the langpacks tests if I can finish up a few other bugs today.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
