>Non constant static vars would be the code smell then, no? If they are being used for any type of states, yes. If they aren't, then I would need to wonder why they are constants. It's difficult to get complete code isolation, and static vars are a good example of where people tend to simply use them. I think, when possible, it's worth going to extra mile to make it isolatable.
Mike
