Hi Its a great topic and good proposal Alberto!
My 2 cents: - I would say we should go with the global configuration and return the last N transactions as part of the Loan details call (associations=ALL or transactions). - Make it optional to not break anything? or shall we go with default 100? I can see pro and con for both… - Let everybody know about this additional configuration and the side effect (if we decide to go with 100) - Introduce the new API where we paginate and sort the transactions and start using that one instead of the Loan details API to fetch the transactions. What do you think fellow Fineract developers and users? Regards, Adam > On 7 Aug 2024, at 17:21, Jose Alberto Hernandez <josealbert...@gmail.com> > wrote: > > Yes, maybe I did not explain the full context: > > Currently, the Loan Account details API uses parameters to get the basic > details and as option the repayment schedule, collaterals, transactions, etc. > Or even to include all these. > > Talking specifically the transaction we can return the most recent N > transactions, not all of them mainly for the performance in the cases that we > have a lot of transaction per Loan > > In the case that we need to explore more transactions we can use the new API > to get the Loan transactions using pagination, but in the previous case If we > want to have the N recent transactions in the Loan Account details API, the > question is How many recent transactions we can use? And as you have > mentioned, we can set this value as a parameter or Global configuration. > > Thanks and Regards > Alberto > > > On Wed, Aug 7, 2024 at 8:52 AM James Dailey <jdai...@apache.org > <mailto:jdai...@apache.org>> wrote: >> Alberto - I think you are "burying the lead". There is a new API that will >> do pagination, which seems like a good idea for longer tenure loans with >> many repayments and also especially for the performance reasons you >> mentioned. Now, you're asking for the value of Number of Transactions to >> return as a preference. >> >> But, why would this not be a value to be set in configuration? And, how >> will this relate to the user interface (mifos web app) - would the web app >> show the number of pages? >> >> In terms of feedback, I think you should consider 10-15 as the starting >> point for the number of transactions to return. But, let's see if anyone >> has a strong opinion. >> >> thanks, >>
