[ 
https://issues.apache.org/jira/browse/FELIX-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-948.
----------------------------------


I removed the spurious casts to Integer and then this looks great :)

Thanks!

> ServiceReferenceImpl.compareTo should handle other types than integer for 
> service ranking
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-948
>                 URL: https://issues.apache.org/jira/browse/FELIX-948
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Carsten Ziegeler
>            Assignee: Richard S. Hall
>             Fix For: felix-1.6.0
>
>
> The ServiceReferenceImpl#compareTo() method currently directly casts the 
> service ranking properties to Integer.
> In Constants.java it reads:
>        * If the supplied property value is not of type
>        * <code>java.lang.Integer</code>, it is deemed to have a ranking value
>        * of zero.
> therefore I think we should check the type before casting and assume a 
> ranking of zero if the type is not integer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to