Hi all, I agree that the ECharts project would benefit from using a deterministic code formatter like prettier. I would vote for doing a single big PR that modifies the code. While it’s true that it will obfuscate git blame to some extent, if the commit message is clear enough, people can check what commit had changed the line in question before the reformatting pass. I have seen many other projects do something similar (I feel these types of changes are pretty much unavoidable as development tools evolve), and as such I think the benefits of making the code more readable will outweigh its disadvantages.
Ville > On 6. Jun 2022, at 10.19, Ovilia <oviliazh...@gmail.com> wrote: > > Hi, > > I would like to know if you think using auto-formatting tools like prettier > is a good idea. > The pros are pretty clear: It helps formatting the code in a uniformed > style without our consideration. > > But for the current code that doesn't follow the style rules, we can choose > a. Fix all the code styles once in a single PR > b. Fix the code styles in a file when it is changed in a future PR > > If we choose plan a, the last change of most lines would be this PR and > lose the help of "git blame". > If we choose plan b, for many times the project would have different styles > over different files and many of future PRs will have styling changings > which make the PR a little harder to review. > > So I would like to know if you think the help from auto-formatting tools is > worth the price and which plan we should take for historical styling > problems. > > Thanks > > *Ovilia* --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
