My vote is +1 binding.
Checked: - The release file is in the right location - Version is correct in package.json - Can build from source. - LICENSE and NOTICE file exist - NOTICE year correct I got an error when build which was not caused by Apache ECharts but some dependent brew libraries were not installed. No package 'pangocairo' found gyp: Call to 'pkg-config pangocairo --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp This can be fixed by installing brew pixman, cairo and pango. [1] My vote is +1 but we should have further discussion on how we could avoid such inconveniences in the future [2]. [1] https://github.com/Automattic/node-canvas/issues/1065#issuecomment-373381272 [2] https://github.com/apache/echarts/issues/14666 Thanks *Ovilia* On Tue, Apr 13, 2021 at 7:45 PM SHUANG SU <sushuang0...@gmail.com> wrote: > FYI > > Comparing to the previous vote, a new file `package-lock.json` is add to > > https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/apache-echarts-5.1.0-rc.1-src.zip > <https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/> > `package-lock.json` fix the issue "typescript build fail", which is found > by Shen Yi in the previous vote. > > But no source code changed and the Github release tag 5.1.0-rc.1 is not > changed. > > Thanks, > ------------------------------ > Su Shuang (100pah) > ------------------------------ > > > > On Tue, 13 Apr 2021 at 19:43, Yi Shen <shenyi....@gmail.com> wrote: > > > I'm not sure what happened but the signature is good now. > > > > > > My vote is +1 binding. > > > > > > Checked: > > > > > > - The release file is in the right location > > > > - Signature and hash are correct. > > > > - Version is correct in package.json > > > > - Can build from source. > > > > - Can run example with built file. > > > > - LICENSE and NOTICE file exist > > > > - NOTICE year correct > > > > > > Thanks > > > > On Tue, Apr 13, 2021 at 7:13 PM Yi Shen <shenyi....@gmail.com> wrote: > > > > > Hi, > > > > > > Seems I can't verify the signature. > > > > > > On Tue, Apr 13, 2021 at 6:17 PM SHUANG SU <sushuang0...@gmail.com> > > wrote: > > > > > >> I am pleased to be calling this vote for the release of Apache ECharts > > >> 5.1.0 (release candidate 1). > > >> > > >> The release candidate to be voted over is available at: > > >> https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/ > > >> > > >> The release candidate is signed with a GPG key available at: > > >> https://dist.apache.org/repos/dist/dev/echarts/KEYS > > >> > > >> The Git commit for this release is: > > >> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=4628dd7 > > >> > > >> The Release Note is available in: > > >> > > > https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/RELEASE_NOTE.txt > > >> > > >> Build Guide: > > >> https://github.com/apache/echarts/blob/5.1.0-rc.1/README.md#build > > >> > > >> Please vote on releasing this package as: > > >> Apache ECharts 5.1.0 (release candidate 1) > > >> by "2021-04-16T11:15:29.743Z". > > >> > > >> [ ] +1 Release this package > > >> [ ] 0 I don't feel strongly about it, but don't object > > >> [ ] -1 Do not release this package because... > > >> > > >> Anyone can participate in testing and voting, not just committers, > > please > > >> feel free to try out the release candidate and provide your votes. > > >> > > >> > > >> Thanks, > > >> ------------------------------ > > >> Su Shuang (100pah) > > >> ------------------------------ > > >> > > > > > > > > > -- > > > Yi Shen > > > Apache ECharts(incubating) PMC > > > > > > > > > -- > > Yi Shen > > Apache ECharts(incubating) PMC > > >
