+1 binding

Checked:

- The release file is in the right location

- Signature and hash are correct.

- Version is correct in package.json

- Can build from source.

- Can run examples with the built file.

- LICENSE and NOTICE file exist

- NOTICE year correct


Regards

On Wed, Jan 13, 2021 at 10:26 AM Ovilia <oviliazh...@gmail.com> wrote:

> +1 (binding)
>
> Checked as follows,
>
>   - The release files are in the correct location.
>   - LICENSE, and NOTICE files exist and the text of each of them is
> correct.
>   - NOTICE year is correct.
>   - Can build successfully from the source and the build instruction is
> clear.
>
> Thanks
>
> *Ovilia*
>
>
> On Wed, Jan 13, 2021 at 8:50 AM Zhongxiang Wang <wan...@apache.org> wrote:
>
> > +1 (binding)
> >
> > Checked as follows,
> >
> >   - The release files are in the correct location.
> >   - The digital signature and hashes are correct.
> >   - LICENSE, and NOTICE files exist and the text of each of them is
> > correct.
> >   - NOTICE year is correct.
> >   - Can build successfully from the source and the build instruction is
> > clear.
> >   - Can run examples with the dist files.
> >
> > Thanks.
> >
> > On Wed, Jan 13, 2021 at 3:08 AM SHUANG SU <sushuang0...@gmail.com>
> wrote:
> >
> > > I am pleased to be calling this vote for the release of Apache ECharts
> > > 5.0.1 (release candidate 1).
> > >
> > > The release candidate to be voted over is available at:
> > > https://dist.apache.org/repos/dist/dev/echarts/5.0.1-rc.1/
> > >
> > > The release candidate is signed with a GPG key available at:
> > > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> > >
> > > The Git commit for this release is:
> > > https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=f9896f0
> > >
> > > The Release Note is available in:
> > >
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.0.1-rc.1/RELEASE_NOTE.txt
> > >
> > > Build Guide:
> > > https://github.com/apache/echarts/blob/5.0.1-rc.1/README.md#build
> > >
> > > Please vote on releasing this package as:
> > > Apache ECharts 5.0.1 (release candidate 1)
> > > by "2021-01-15T20:02:50.088Z".
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > > Anyone can participate in testing and voting, not just committers,
> please
> > > feel free to try out the release candidate and provide your votes.
> > >
> > > --------------------------
> > >
> > > Thanks,
> > > ------------------------------
> > >  Su Shuang (100pah)
> > > ------------------------------
> > >
> >
>


-- 
Yi Shen
Apache ECharts(incubating) PMC

Reply via email to