[GitHub] [incubator-echarts-bot] plainheart opened a new pull request #7: fix: use `isCoreCommitter` instead of `isCommitter` to be compatible with the committers who are hiding their membership in organization.

[GitBox]

plainheart opened a new pull request #7:
URL: https://github.com/apache/incubator-echarts-bot/pull/7


   Currently, the bot won't add the label `PR: revision needed` when a 
committer requests changes.
   
   I made some tests in my own repository, and the result indicates that 
   there may be a flaw in the function 
[`isCommitter`](https://github.com/apache/incubator-echarts-bot/blob/master/index.js#L177-L179)
 if a committer is hiding his/her membership in the organization, 
   that is the `author_association` of this committer may be not `MEMBER` but 
`CONTRIBUTOR` for the other public people, so does the bot.
   
   I'm not sure about this, since I have no private organization to check.
   
   ![Hide membership in the 
organization](https://user-images.githubusercontent.com/26999792/91119947-1ac1a480-e6c7-11ea-9f4d-42f3f3589daa.png)
   
   ![Show membership in the 
organization](https://user-images.githubusercontent.com/26999792/91119949-1d23fe80-e6c7-11ea-9a5e-0d0b53421814.png)
   
   ![Show membership in the 
organization](https://user-images.githubusercontent.com/26999792/91120100-72f8a680-e6c7-11ea-98de-a36e29a74e3d.png)
   
   ![Organization visibility: 
Public](https://user-images.githubusercontent.com/26999792/91120148-928fcf00-e6c7-11ea-9000-2426f20fa940.png)
   
   ![Organization visibility: 
Private](https://user-images.githubusercontent.com/26999792/91120501-645ebf00-e6c8-11ea-888f-5d50aa454841.png)
   
   
![image](https://user-images.githubusercontent.com/26999792/91120548-80faf700-e6c8-11ea-82ef-0347a7607662.png)
   
   ---
   Additionally, Updated some texts.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org