+1 binding

Checked:

The release file is in the right location

LICENSE and NOTICE file exist

NOTICE year correct

Signature and hash are correct.

Can build from source

Can run with build

Ovilia <oviliazh...@gmail.com> 于2020年3月5日周四 上午11:16写道:

> +1 binding
>
>
> I checked:
>
> ☐ Are release files in correct location?
>
> ☐ Do release files have the word incubating in their name?
>
> ☐ Does DISCLAIMER file exist?
>
> ☐ Do LICENSE and NOTICE files exists?
>
> ☐ Is the LICENSE and NOTICE text correct?
>
> ☐ Is the NOTICE year correct?
>
> ☐ License information is not mentioned in NOTICE?
>
> ☐ Do the contents of the release match with what's tagged in version
> control?
>
> ☐ Are there any unexpected binary files in the release?
>
> ☐ Can you compile from source? Are the instruction clear?
>
>
>
> Thanks
>
> Wenli
>
>
> On Mon, Mar 2, 2020 at 5:57 PM Yi Shen <shenyi....@gmail.com> wrote:
>
> > +1 binding
> >
> >
> > Checked:
> >
> >
> > - The release file is in the right location
> >
> > - Signature and hash are correct.
> >
> > - Version is correct in package.json
> >
> > - Built successfully from source.
> >
> > - Can run examples with built lib.
> >
> > - Source files have no diff with the release branch on GitHub
> >
> > - LICENSE and NOTICE file exist
> >
> > - NOTICE year correct
> >
> > On Mon, Mar 2, 2020 at 5:45 PM SHUANG SU <sushuang0...@gmail.com> wrote:
> >
> > > I am pleased to be calling this vote for the release of Apache ECharts
> > > (incubating) 4.7.0 (release candidate 1).
> > >
> > > The release candidate to be voted over is available at:
> > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.7.0-rc.1/
> > >
> > > The release candidate is signed with a GPG key available at:
> > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
> > >
> > > The Git commit for this release is:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=4f3748d
> > >
> > > The Release Note is available in:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.7.0-rc.1/RELEASE_NOTE.txt
> > >
> > > Build Guide:
> > >
> >
> https://github.com/apache/incubator-echarts/blob/4.7.0-rc.1/README.md#build
> > >
> > > Please vote on releasing this package as:
> > > Apache ECharts (incubating) 4.7.0 (release candidate 1)
> > > by "2020-03-05T10:42:32.452Z".
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > > Anyone can participate in testing and voting, not just committers,
> please
> > > feel free to try out the release candidate and provide your votes.
> > >
> > > A checklist for reference:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> > >
> > > Thanks,
> > > ------------------------------
> > >  Su Shuang (100pah)
> > > ------------------------------
> > >
> >
> >
> > --
> > Yi Shen
> > Apache ECharts(incubating) PPMC
> >
>

Reply via email to