Hi Willem, thanks for the reminding. Currently we will do regression test on the release branch before we start the vote. So I only checked the build process and diff between source release and git release branch to make sure nothing unexpected happened when creating source release from the git branch.
On Sun, Dec 15, 2019 at 2:34 PM Willem Jiang <willem.ji...@gmail.com> wrote: > Just a reminder for the PPMC voting. > We should mainly focus on the functional test by running some test > with demo or doing some verification as user does on the release > candidate. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Sun, Dec 15, 2019 at 1:46 PM siwen su <susiw...@gmail.com> wrote: > > > > +1 > > > > Checked: > > > > - The release file is in the right location > > - Signature and hash are correct. > > - Version is correct in package.json > > - Can build from source. > > - Source files have no diff with the release branch on GitHub > > - LICENSE and NOTICE file exist > > - NOTICE year correct > > > > Yi Shen <shenyi....@gmail.com> 于2019年12月15日周日 下午12:28写道： > > > > > Sorry for the late vote. > > > > > > Mine is +1 binding > > > > > > Checked: > > > > > > - The release file is in the right location > > > - Signature and hash are correct. > > > - Version is correct in package.json > > > - Can build from source. > > > - Source files have no diff with the release branch on GitHub > > > - LICENSE and NOTICE file exist > > > - NOTICE year correct > > > > > > > > > On Thu, Dec 12, 2019 at 11:14 PM SHUANG SU <sushuang0...@gmail.com> > wrote: > > > > > > > I am pleased to be calling this vote for the release of Apache > ECharts > > > > (incubating) 4.6.0 (release candidate 1). > > > > > > > > The release candidate to be voted over is available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.6.0-rc.1/ > > > > > > > > The release candidate is signed with a GPG key available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > > > The Git commit for this release is: > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=f4fc1b0 > > > > > > > > The Release Note is available in: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.6.0-rc.1/RELEASE_NOTE.txt > > > > > > > > Build Guide: > > > > > > > > https://github.com/apache/incubator-echarts/blob/4.6.0-rc.1/README.md#build > > > > > > > > Please vote on releasing this package as: > > > > Apache ECharts (incubating) 4.6.0 (release candidate 1) > > > > by "2019-12-15T16:11:12.152Z". > > > > > > > > [ ] +1 Release this package > > > > [ ] 0 I don't feel strongly about it, but don't object > > > > [ ] -1 Do not release this package because... > > > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > > feel free to try out the release candidate and provide your votes. > > > > > > > > A checklist for reference: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > Thanks, > > > > ------------------------------ > > > > Su Shuang (100pah) > > > > ------------------------------ > > > > > > > > > > > > > -- > > > Yi Shen > > > Apache ECharts(incubating) PPMC > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org > For additional commands, e-mail: dev-h...@echarts.apache.org > > -- Yi Shen Apache ECharts(incubating) PPMC
