+1 binding I checked:
- The release file is in the right location - Signature and hash are correct. - Version is correct in package.json - Can build from source. - Source files have no diff with the release branch on GitHub - LICENSE and NOTICE file exist - NOTICE year correct Wenli On Mon, Nov 11, 2019 at 11:35 AM Deqing Li <annong...@gmail.com> wrote: > +1 binding > > Checked: > + The release file is in the right location. > + Version is correct in package.json. > + LICENSE and NOTICE file exist > > > Yi Shen <shenyi....@gmail.com> 于2019年11月8日周五 下午8:46写道： > > > +1 binding > > > > Checked: > > > > - The release file is in the right location > > - Signature and hash are correct. > > - Version is correct in package.json > > - Can build from source. > > - Source files have no diff with the release branch on GitHub > > - LICENSE and NOTICE file exist > > - NOTICE year correct > > > > On Fri, Nov 8, 2019 at 8:23 PM SHUANG SU <sushuang0...@gmail.com> wrote: > > > > > I am pleased to be calling this vote for the release of Apache ECharts > > > (incubating) 4.5.0 (release candidate 2). > > > > > > The release candidate to be voted over is available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.5.0-rc.2/ > > > > > > The release candidate is signed with a GPG key available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > The Git commit for this release is: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=0ebdeaf4 > > > > > > The Release Note is available in: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.5.0-rc.2/RELEASE_NOTE.txt > > > > > > Build Guide: > > > > > > https://github.com/apache/incubator-echarts/blob/4.5.0-rc.2/README.md#build > > > > > > Please vote on releasing this package as: > > > Apache ECharts (incubating) 4.5.0 (release candidate 2) > > > by "2019-11-11T13:21:31.230Z". > > > > > > [ ] +1 Release this package > > > [ ] 0 I don't feel strongly about it, but don't object > > > [ ] -1 Do not release this package because... > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > feel free to try out the release candidate and provide your votes. > > > > > > A checklist for reference: > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > Thanks, > > > ------------------------------ > > > Su Shuang (100pah) > > > ------------------------------ > > > > > > > > > -- > > Yi Shen > > Apache ECharts(incubating) PPMC > > >
