I tried with the autotest framework today. I had to say, that's really awesome! Excellent job, Shen!
Wenli On Mon, Sep 16, 2019 at 9:22 PM SHUANG SU <sushuang0...@gmail.com> wrote: > > I should create only one test file, and put all the test cases about > different series in this file? > > Yes, I think so. > They are all about the feature clip. > > Thanks, > ------------------------------ > Su Shuang (100pah) > ------------------------------ > > > > On Mon, 16 Sep 2019 at 20:06, Yi Shen <shenyi....@gmail.com> wrote: > > > > > > > I think I can add a command line tool to generate a test html file. > > > > > > Good to hear! > > > > > For example, > > > the name should be started by > > > + a chart name (like, `line-xxx-xxx.html`) > > > + or a component name (like, `visualMap-xxx-xxx.html` or > > > `visual-map-xxx-xxx.hmtml` ? ) > > > + or a common feature name (like, `haveStyle.html`, > `label-xxx-xxx.html`) > > > > > > So if I'm planning to add a feature about clip[1], which is related to > most > > of the series. > > I should create only one test file, and put all the test cases about > > different series in this file? > > Am I understanding correctly? > > > > [1] https://github.com/apache/incubator-echarts/issues/11240 > > > > > > SHUANG SU <sushuang0...@gmail.com> 于2019年9月16日周一 下午7:14写道： > > > > > If each test case a html file, it results in too many html files added, > > > which are hard to visit by category and management. If adding multiple > > > test cases in one file, not easy to find a rule about which case should > > > be in which file. > > > > > > In my opinion, it essentially the same as "how to classify test cases". > > > We used to write test cases in this framework: > > > ```js > > > describe('some test suite', function () { > > > it('a test case', function () { > > > > > > }); > > > }); > > > ``` > > > > > > Similarly, > > > > > > a-test-file.html > > > test-case-chart1 > > > test-case-chart2 > > > ... > > > > > > I have been generating test html file (Can be considered as a test > suite) > > > based on `echarts/test/tmp-base.html`. > > > And add charts (can be considered as test cases) into the file. > > > > > > Test suites can be classify by features in coarse granularity. > > > For example, add cases about "hover state" into "hoverStyle.html", > > > add cases about large bar into "bar-large.html". > > > > > > I think I can add a command line tool to generate a test html file. > > > And we should probably have some guide or rule of the naming of these > > file. > > > For example, > > > the name should be started by > > > + a chart name (like, `line-xxx-xxx.html`) > > > + or a component name (like, `visualMap-xxx-xxx.html` or > > > `visual-map-xxx-xxx.hmtml` ? ) > > > + or a common feature name (like, `haveStyle.html`, > `label-xxx-xxx.html`) > > > > > > > > > -- > > Yi Shen > > Senior Developer > > Baidu, Inc. > > >
