+1 binding. I checked: - release files is in correct location - release files have the word incubating in their name - the digital signature and hashes are correct - DISCLAIMER file exists - LICENSE and NOTICE files exists - LICENSE and NOTICE text are correct - NOTICE year is correct - Un-included software dependencies are not mentioned in LICENSE or NOTICE - License information is not mentioned in NOTICE - The contents of the release match with what's tagged in version control - no binary files in the release - compile from source
Wenli On Sun, Sep 8, 2019 at 8:51 PM Deqing Li <annong...@gmail.com> wrote: > +1 (binding) > > > 沈毅 <shenyi....@gmail.com> 于2019年9月8日周日 下午6:30写道： > > > My vote is +1(binding) > > > > > On Sep 8, 2019, at 5:47 PM, SHUANG SU <sushuang0...@gmail.com> wrote: > > > > > > I am pleased to be calling this vote for the release of Apache ECharts > > > (incubating) 4.3.0 (release candidate 2). > > > > > > The release candidate to be voted over is available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/ > > > > > > The release candidate is signed with a GPG key available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > The Git commit for this release is: > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=739033d > > > > > > The Release Note is available in: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/RELEASE_NOTE.txt > > > > > > > > > *** > > > The changes from Apache ECharts (incubating) 4.3.0 (release candidate > 1): > > > > > > (1) Remove the author tags that are not removed. Author tag is brought > by > > > previous > > > code style but has been not recommanded any more for long time. > > > (2) Remove the code snippet that has copyright issue from > > > `./src/component/toolbox/feature/DataView.js`. > > > (3) The previous code snippet that has copyright issue in > > > `./src/component/brush/selector.js` is > > > from a blog but seems like originally from a online lecture of an > > > university (where the link is not able to access). > > > We remove it and rewrite the code based on the fundamental math > > derivation. > > > (4) Remove all of the old website link `http://echarts.baidu.com` from > > the > > > comments of the code. > > > > > > More details can be checked in: > > > https://github.com/apache/incubator-echarts/compare/b62ab99...739033d > > > *** > > > > > > > > > Some shell commands for validating the release: > > > > > > ```shell > > > # Download the release: > > > curl > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/apache-echarts-4.3.0-rc.2-incubating-src.zip > > > -o apache-echarts-4.3.0-rc.2-incubating-src.zip > > > unzip apache-echarts-4.3.0-rc.2-incubating-src.zip -d > > > apache-echarts-4.3.0-rc.2-incubating-src > /dev/null > > > > > > # Build the project (Node.js environment is required): > > > cd "apache-echarts-4.3.0-rc.2-incubating-src" && npm install && cd .. > > > node "apache-echarts-4.3.0-rc.2-incubating-src/build/build.js" > --release > > > # (See help: `node > > > "apache-echarts-4.3.0-rc.2-incubating-src/build/build.js" --help`) > > > ``` > > > > > > > > > Please vote on releasing this package as: > > > Apache ECharts (incubating) 4.3.0 (release candidate 2) > > > by "2019-09-11T09:57:02.306Z". > > > > > > [ ] +1 Release this package > > > [ ] 0 I don't feel strongly about it, but don't object > > > [ ] -1 Do not release this package because... > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > feel free to try out the release candidate and provide your votes. > > > > > > A checklist for reference: > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > ------------------------------ > > > Su Shuang (100pah) > > > ------------------------------ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org > > For additional commands, e-mail: dev-h...@echarts.apache.org > > > > >
