About #10224, #10010, #9200, currently, the only case that looks good is in `line chart`: `echarts/test/dataZoom-clip.html` It based on (1) set clip path for line group when is rendered in `grid` and `polor`. (2) set `fileterMode: "none"` on dataZoom (if dataZoom exists)
Do we still follow this approach? that is, give some options to determine whether set clip path in `grid` and `polor` (or generally, all of the coord system that may need clip). But this logic probably should be implemented based on coord system, but not in chart view any more. (and can be slitghtly customized by chart view, for example, in line chart the clip path is enlarged a bit with the symbol radius to avoid to cut symbols when they are on the edge of the clip area) [1] https://github.com/apache/incubator-echarts/issues/10224 https://github.com/apache/incubator-echarts/issues/10010 https://github.com/apache/incubator-echarts/issues/9200 ------------------------------ Su Shuang (100pah) ------------------------------ On Sat, 31 Aug 2019 at 16:45, Ovilia <oviliazh...@gmail.com> wrote: > I agree with Yi Shen. #10224, #10010, #9200 are of very high priority and > should be fixed ASAP. > We shouldn't always say they need to be fixed later because they are > complicated. > We have assessed the expected time to fix these issues offline, and it is > possible to fix them in this version. The only thing we need is to discuss > them into more technical details, rather than putting them into the next > milestone. > > I'd suggest they be fixed together. Deqing may find something else to fix. > The updated milestone can be found at: > https://github.com/apache/incubator-echarts/milestone/12 > > Wenli > > > On Fri, Aug 30, 2019 at 11:47 PM Yi Shen <shenyi....@gmail.com> wrote: > > > > > > > Consider the difficulty of #10224, #10010, #9200 (the clip issue), > > > maybe #10164 (the tree bug) can be handled first, I think. > > > > > > > We should discuss more about the complexity of fixing the clipping and > > dataZoom issue and determine > > if they can be fixed in this version. As my perspective, these three > issues > > in the list are important to user experience and should be fixed ASAP. > > > > > > On Fri, Aug 30, 2019 at 11:30 PM SHUANG SU <sushuang0...@gmail.com> > wrote: > > > > > Consider the difficulty of #10224, #10010, #9200 (the clip issue), > > > maybe #10164 (the tree bug) can be handled first, I think. > > > > > > > > > ------------------------------ > > > Su Shuang (100pah) > > > ------------------------------ > > > > > > > > > > > > On Fri, 30 Aug 2019 at 22:19, Yi Shen <shenyi....@gmail.com> wrote: > > > > > > > Hi Deqing. > > > > > > > > Issues #10224[1], #10010[2], #9200[3] are related. Which are all > about > > > > following two questions. > > > > > > > > (1) Weather we should clip the grid area when the chart content > exceed > > > the > > > > x axis or y axis. > > > > (2) How should we improve current dataZoom component filtering > > strategy. > > > > Currently it will filter out all the data not in the window. But in > the > > > > case described in #10224, it not works well. And a better strategy is > > > still > > > > keeping the data near to the window > > > > and apply the clip I mentioned before. > > > > > > > > I think these issues should be fixed together in this version. The > > issue > > > > #10164 you bring up is also a serious one. I agree we fixing it in > this > > > > version. > > > > > > > > [1] https://github.com/apache/incubator-echarts/issues/10224 > > > > [2] https://github.com/apache/incubator-echarts/issues/10010 > > > > [3] https://github.com/apache/incubator-echarts/issues/9200 > > > > > > > > > > > > > > > > On Fri, Aug 30, 2019 at 9:51 PM Deqing Li <annong...@gmail.com> > wrote: > > > > > > > > > Dear All, > > > > > I just want to change Issue #10224( > > > > > https://github.com/apache/incubator-echarts/issues/10224) to issue > > > > #10164( > > > > > https://github.com/apache/incubator-echarts/issues/10164), because > > > many > > > > > users have met this bug and hope us to fix it a long time ago. > > > > > > > > > > Ovilia <oviliazh...@gmail.com> 于2019年8月27日周二 下午1:58写道： > > > > > > > > > > > v4.4.0 will be the version number of the next release after the > one > > > we > > > > > are > > > > > > currently testing. > > > > > > > > > > > > The schedule for v4.4.0 is: > > > > > > Kickoff (discuss features to fix or enhance): 26th Aug - 1st Sep > > > > > > Development: 2nd - 22nd Sep > > > > > > Test and release vote: 23rd - 30 Sep > > > > > > > > > > > > Here I listed several issues that I suggest to be fixed in this > > > version > > > > > > [1]. > > > > > > Please note that these issues are currently only my suggestion, > not > > > > final > > > > > > decisions. > > > > > > Those closed ones in the list are the ones fixed previously but > not > > > > > > included in v4.3.0, the version we are currently testing. > > > > > > > > > > > > PPMC should discuss the list and decide the final list on 30th > Aug. > > > > > > Before then, PPMC may add what you think should be fixed in this > > > > version > > > > > to > > > > > > the milestone [1] to be discussed. > > > > > > The community is also welcomed to suggest what issues to be fixed > > > with > > > > a > > > > > > higher priority. > > > > > > > > > > > > [1] https://github.com/apache/incubator-echarts/milestone/12 > > > > > > > > > > > > > > > > > > Wenli > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Yi Shen > > > > Senior Developer > > > > Baidu, Inc. > > > > > > > > > > > > > -- > > Yi Shen > > Senior Developer > > Baidu, Inc. > > >
