Hi, Missed this thread.
This one should be included in the Druid 33: https://github.com/apache/druid/pull/17749 We need this one. I will create a backport PR to the Druid 33 branch. Thanks. On Thu, Apr 3, 2025 at 3:46 AM Zoltan Haindrich <k...@rxd.hu> wrote: > Hello, > > In the last couple days there were some PRs labeled&merged for 33 in [1] > I believe the remaining two is also pretty close; they are reasonably > small and possibly cherry-picked as well - so I plan to create the branch > tomorrow! > > cheers, > Zoltan > > > [1] https://github.com/apache/druid/milestone/61 > > On 4/1/25 10:47, Zoltan Haindrich wrote: > > Hey, > > > > I was peeking into this wether just dropping in GraalJS was an option or > not...and it seems very promising with the nashorn compat flag turned on > [1]. > > Maytas: what do you think about it? could you please take a look? > > > > While I was looking around I've also notice that we also use another > javascript engine Rhino [1] in `JavaScriptDimFilter` - I feel like we > should reduce the number > > of javascript engines if possible. > > > > cheers, > > Zoltan > > > > [1] https://github.com/apache/druid/pull/17843 > > [2] https://github.com/mozilla/rhino > > > > > > > > On 3/27/25 07:13, Zoltan Haindrich wrote: > >> Hey, > >> > >> It seems to me that we don't directly use nashorn in this case - its > being used thru ScriptEngineManager to access it. > >> > >> I believe this kind of usage could be okay if we don't directly depend > on that library: > >> * add a configuration option to choose which scriptengine the user > wants to use > >> * provide instructions that an accessible javascript engine is need for > this to work > >> * as an example the procedure for nashorn could be included - it > only has org.ow2.asm dependencies which will be already on the classpath > >> * I wonder if we could have nashorn loaded in for testing purposes (it > won't be in the final binary release) > >> * I feel like this will be okay - we could probably add a maven > profile to load nashorn > >> I think this could be a way to keep using Nashorn. > >> > >> It seems to me there is another possible option to use GraalVM; > wouldn't that work ? > >> > >> cheers, > >> Zoltan > >> > >> > >> > >> On 3/26/25 08:30, Maytas Monsereenusorn wrote: > >>> Hi, > >>> > >>> We discussed adding back the support for Javascript (Javascript tiered > >>> broker selector strategy and Javascript filter) which is now broken if > >>> Druid is running Java 17 and above. > >>> The comment is at > >>> https://github.com/apache/druid/pull/14795#issuecomment-2650127506 > and the > >>> pull request is https://github.com/apache/druid/pull/14795 > >>> However, I think this pull request cannot be merge as > org.openjdk.nashor is > >>> under GNU General Public License v2.0. (please correct me if I'm wrong) > >>> > >>> Thanks, > >>> Maytas > >>> > >>> > >>> On Wed, Mar 26, 2025 at 12:22 AM Zoltan Haindrich <k...@rxd.hu> wrote: > >>> > >>>> Hello all, > >>>> > >>>> To keep the regular pace of Druid releases; 33.0.0 should be rolled > out in > >>>> the upcoming month or so. > >>>> I would like to volunteer to be the release manager for this one. > >>>> Based on the earlier schedules we could target Apr 1 for branch cut - > but > >>>> lets discuss if there are some important things which should be > included! > >>>> Anyway if there is anything which should be discussed please reply to > this > >>>> thread and mark it on github with the 33.0.0 milestone [1] so that it > >>>> doesn't fall off the radar! > >>>> > >>>> cheers, > >>>> Zoltan > >>>> > >>>> [1] https://github.com/apache/druid/milestone/61 > >>>> > >>>> > >>> > >> > > > >
