Hi Liran, thank you for the report (and the nice PR!). Yes, this bug is not a regression and probably has been there for a long time, so I would say we can make a release without the fix this time. In fact, the OffheapIncrementalIndex is not in use widely in production code. It is used in groupBy v1 when you explicitly set "useOffheap" in the query context. Also, the groupBy v1 is deprecated in favor of groupBy v2. To be honest, I think we should drop OffheapIncrementalIndex rather than fixing the bug.
Anyway, I hope to have some time soon to take a look at your PR. Jihoon On Mon, Jun 15, 2020 at 8:57 AM Liran Funaro <liran.fun...@verizonmedia.com.invalid> wrote: > Hi, > > I found a bug in the > OffheapIncrementalIndex: ArrayIndexOutOfBoundsException when initialized > with an empty metric list. > It might be the reason for issue #8922, but I can't know for sure without > additional information. > Note that this bug exists in previous versions. > > The fix is published as part of a larger PR (#10001). Specifically, the fix > and the additional tests that discover this bug are available in the > following commit: > > https://github.com/apache/druid/pull/10001/commits/c4771c178f20567c737adb76cefc7b69dec2a026 > . > Please check it out and let me know if you wish to add this fix to this > release. > If so, I will separate this specific fix to a detached PR so it can be > reviewed and merged. > > Thanks, > Liran Funaro > > On 2020/06/15 01:43:26, Clint Wylie <c...@apache.org> wrote: > > Hi all,> > > > > It's about that time again to start preparing to make the next release > (the> > > last major branch was created in March) - I volunteer to be release> > > manager. I will probably try to make the branch sometime in the next > week> > > or so, to allow us time to start seriously testing to get everything in > the> > > branch stable and ready to go.> > > > > If anyone is aware of any bugs which should be addressed before release,> > > please mention them in this thread so we can discuss and potentially tag> > > them to the milestone and try to get fixes in place.> > > > > Cheers,> > > Clint> > > >
