-----Original Message----- > Date: Thu, 3 May 2018 06:03:01 +0000 > From: "Gujjar, Abhinandan S" <abhinandan.guj...@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > CC: "hemant.agra...@nxp.com" <hemant.agra...@nxp.com>, > "akhil.go...@nxp.com" <akhil.go...@nxp.com>, "dev@dpdk.org" > <dev@dpdk.org>, "Vangati, Narender" <narender.vang...@intel.com>, "Rao, > Nikhil" <nikhil....@intel.com>, "Eads, Gage" <gage.e...@intel.com> > Subject: RE: [v2,1/6] eventdev: introduce event crypto adapter > > > > > -----Original Message----- > > From: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Sent: Sunday, April 29, 2018 9:39 PM > > To: Gujjar, Abhinandan S <abhinandan.guj...@intel.com> > > Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati, > > Narender <narender.vang...@intel.com>; Rao, Nikhil <nikhil....@intel.com>; > > Eads, Gage <gage.e...@intel.com> > > Subject: Re: [v2,1/6] eventdev: introduce event crypto adapter > > > > -----Original Message----- > > > Date: Tue, 24 Apr 2018 18:13:22 +0530 > > > From: Abhinandan Gujjar <abhinandan.guj...@intel.com> > > > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > > > akhil.go...@nxp.com, dev@dpdk.org > > > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > > > nikhil....@intel.com, gage.e...@intel.com > > > Subject: [v2,1/6] eventdev: introduce event crypto adapter > > > X-Mailer: git-send-email 1.9.1 > > > > > > Signed-off-by: Abhinandan Gujjar <abhinandan.guj...@intel.com> > > > Signed-off-by: Nikhil Rao <nikhil....@intel.com> > > > Signed-off-by: Gage Eads <gage.e...@intel.com> > > > --- > > > lib/librte_eventdev/rte_event_crypto_adapter.h | 532 > > > +++++++++++++++++++++++++ > > > 1 file changed, 532 insertions(+) > > > create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h > > > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h > > > b/lib/librte_eventdev/rte_event_crypto_adapter.h > > > new file mode 100644 > > > index 0000000..aa4f32c > > > --- /dev/null > > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h > > > @@ -0,0 +1,532 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(c) 2017-2018 Intel Corporation */ > > > + > > > +#ifndef _RTE_EVENT_CRYPTO_ADAPTER_ > > > +#define _RTE_EVENT_CRYPTO_ADAPTER_ > > > > Please reword if it makes sense. > It is to the adapter through eventdev. > May be elaborating little more something like, application gets crypto > adapter's > event port by rte_event_crypto_adapter_event_port_get() API. > Application links it's event queue to this event port and starts enqueuing > crypto > operations as events. Adapter dequeue these events and submit the crypto > operations > to the cryptodev. > > Does this make sense?
Yes > > > + RTE_EVENT_CRYPTO_ADAPTER_DEQ_ONLY = 1, > > > > Why to mark it as explicit '1' ? > Nothing specific. Have 0 & 1? Let have 0 then so that enum you don't need to specify '0' explicit as enum starts from 0 Thanks for the comments. Looks like we have sorted out all the issues.
