On Fri, Apr 27, 2018 at 04:55:20PM +0100, Ferruh Yigit wrote: > On 4/27/2018 4:42 PM, Neil Horman wrote: > > On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote: > >> Remove version tag from experimental block in linker version scripts > >> (.map files). > >> > >> That label is not used by linker and information only. It is useful > >> for version blocks but not useful for experimental block but confusing. > >> Removing those labels. > >> > >> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > >> --- > >> Cc: Neil Horman <nhor...@tuxdriver.com> > >> Cc: Thomas Monjalon <tho...@monjalon.net> > >> --- > >> drivers/net/dpaa/rte_pmd_dpaa_version.map | 4 +--- > >> lib/librte_cryptodev/rte_cryptodev_version.map | 2 +- > >> lib/librte_eal/rte_eal_version.map | 2 +- > >> lib/librte_ethdev/rte_ethdev_version.map | 2 +- > >> lib/librte_eventdev/rte_eventdev_version.map | 2 +- > >> lib/librte_mbuf/rte_mbuf_version.map | 3 +-- > >> lib/librte_mempool/rte_mempool_version.map | 3 +-- > >> lib/librte_meter/rte_meter_version.map | 2 +- > >> lib/librte_net/rte_net_version.map | 2 +- > >> lib/librte_pipeline/rte_pipeline_version.map | 2 +- > >> lib/librte_vhost/rte_vhost_version.map | 2 +- > >> 11 files changed, 11 insertions(+), 15 deletions(-) > >> > >> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> b/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> index 3b937b10f..c7ad4030a 100644 > >> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> @@ -9,6 +9,4 @@ EXPERIMENTAL { > >> dpaa_eth_eventq_attach; > >> dpaa_eth_eventq_detach; > >> rte_pmd_dpaa_set_tx_loopback; > >> - > >> - local: *; > > Are you sure you meant to remove this local tag? > > Yes, it was a duplicate, above DPDK_17.11 one has it already. > copy that, thanks Acked-by: Neil Horman <nhor...@tuxdriver.com>
> > > > Everything else looks good > > > > Neil > > > >