On 27-Apr-18 4:57 PM, Van Haaren, Harry wrote:
From: dev [mailto:[email protected]] On Behalf Of Anatoly Burakov Sent: Wednesday, April 25, 2018 11:16 AM To: [email protected] Cc: [email protected]; Burakov, Anatoly <[email protected]> Subject: [dpdk-dev] [PATCH v2 3/3] malloc: fix potential dereferencing of NULL pointerPrevious code checked for both first/last elements being NULL, but if they weren't, the expectation was that they're both non-NULL, which will be the case under normal conditions, but may not be the case due to heap structure corruption. Coverity issue: 272566 Fixes: bb372060dad4 ("malloc: make heap a doubly-linked list") Cc: [email protected] Signed-off-by: Anatoly Burakov <[email protected]>Had to do a double-take there - that's a novel way of checking pointers - but it actually makes sense here :) Acked-by: Harry van Haaren <[email protected]>
It's basically a logical XOR :) Thanks for reviewing! -- Thanks, Anatoly
