On 27-Apr-18 4:57 PM, Van Haaren, Harry wrote:
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Wednesday, April 25, 2018 11:16 AM To: dev@dpdk.org Cc: tho...@monjalon.net; Burakov, Anatoly <anatoly.bura...@intel.com> Subject: [dpdk-dev] [PATCH v2 3/3] malloc: fix potential dereferencing of NULL pointerPrevious code checked for both first/last elements being NULL, but if they weren't, the expectation was that they're both non-NULL, which will be the case under normal conditions, but may not be the case due to heap structure corruption. Coverity issue: 272566 Fixes: bb372060dad4 ("malloc: make heap a doubly-linked list") Cc: anatoly.bura...@intel.com Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>Had to do a double-take there - that's a novel way of checking pointers - but it actually makes sense here :) Acked-by: Harry van Haaren <harry.van.haa...@intel.com>
It's basically a logical XOR :) Thanks for reviewing! -- Thanks, Anatoly
