Hi, On Wed, Apr 25, 2018 at 01:00:23AM +0200, Thomas Monjalon wrote: > Can we have this patchset in 18.05-rc1? > Or is it candidate to rc2?
I realized I made my comments on v1 instead of v2, sorry. https://dpdk.org/dev/patchwork/patch/36538/ https://dpdk.org/dev/patchwork/patch/36535/ https://dpdk.org/dev/patchwork/patch/36533/ All of them are minor issues, they could be adressed for rc2. Will send acks for generic mempool part. Olivier > > 16/04/2018 15:33, Andrew Rybchenko: > > The patch series adds bucket mempool driver which allows to allocate > > (both physically and virtually) contiguous blocks of objects and adds > > mempool API to do it. It is still capable to provide separate objects, > > but it is definitely more heavy-weight than ring/stack drivers. > > The driver will be used by the future Solarflare driver enhancements > > which allow to utilize physical contiguous blocks in the NIC firmware. > > > > The target usecase is dequeue in blocks and enqueue separate objects > > back (which are collected in buckets to be dequeued). So, the memory > > pool with bucket driver is created by an application and provided to > > networking PMD receive queue. The choice of bucket driver is done using > > rte_eth_dev_pool_ops_supported(). A PMD that relies upon contiguous > > block allocation should report the bucket driver as the only supported > > and preferred one. > [...] > > Andrew Rybchenko (1): > > doc: advertise bucket mempool driver > > > > Artem V. Andreev (5): > > mempool/bucket: implement bucket mempool manager > > mempool: implement abstract mempool info API > > mempool: support block dequeue operation > > mempool/bucket: implement block dequeue operation > > mempool/bucket: do not allow one lcore to grab all buckets