> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 24, 2018 1:45 AM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>; tho...@monjalon.net
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org;
> Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>;
> Lu, Wenzhuo <wenzhuo...@intel.com>
> Subject: Re: [PATCH v7 4/5] app/testpmd: enable queue ring size configure
>
> On 4/22/2018 12:58 PM, Qi Zhang wrote:
> > Add command to change specific queue's ring size configure, the new
> > value will only take effect after command that restart the device(port
> > stop <port_id>/port start <port_id>) or command that setup the
> > queue(port <port_id> rxq <qid> setup) at runtime.
> >
> > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 102
> ++++++++++++++++++++++++++++
> > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++
> > 2 files changed, 111 insertions(+)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > b50e11e60..22e4d4585 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -846,6 +846,11 @@ static void cmd_help_long_parsed(void
> *parsed_result,
> > "port config mtu X value\n"
> > " Set the MTU of port X to a given value\n\n"
> >
> > + "port config (port_id) (rxq|txq) (queue_id) ring_size
> > (value)\n"
> > + " Set a rx/tx queue's ring size configuration, the
> > new"
> > + " value will take effect after command that (re-)start
> > the port"
> > + " or command that setup the specific queue\n\n"
>
> "port config all rxq|txq|rxd|txd <value>" is used to set number of queues
> (rxq) or number of descriptors in queue (rxd).
>
> Problem is this is not flexible and your version is better.
>
> What do you think removing old rxd|txd part with this patch, to prevent
> duplication?
I'm not sure.
Do we need some command to reset all queue's ring size to default value.
Probably we need to support "all" syntax on new command before consider remove
this.
Also per queue config will be reset to original command line parameter by any
command that call init_port_config, (for example: port config all rxq ...)
while "port config all rxd ..." modify the command line value, so they are
different
Regards
Qi
