On Mon, Apr 23, 2018 at 12:17:09PM +0100, Doherty, Declan wrote: > On 23/04/2018 12:00 PM, Shahaf Shuler wrote: > > Thursday, April 19, 2018 4:03 PM, Adrien Mazarguil: > > > Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap > > > actions > > > > > > On Wed, Apr 18, 2018 at 10:04:18PM +0100, Declan Doherty wrote: > > > > [...] > > > > > > > > I'm still unsure about the definition involving a list of items. I > > > imagined > > > these actions even less generic than that. How about tagging them > > > EXPERIMENTAL until sorted out through the first PMD implementation? > > > > I think every new API should be marked as experimental. At least for one > > release. > > Here in specific, because there is no actual implementation of those APIs > > in any of the drivers. > > > > On this, since these are just new structures to use with existing APIs is > using the following tag in the doxygen comments sufficient? > > /** > * @warning > * @b EXPERIMENTAL: this structure may change without prior notice > */
Looks good to me. I did not realize we already had such a thing in DPDK (eventdev). > > > (We could even provide forward declarations only to prevent applications > > > from using them in the meantime.) -- Adrien Mazarguil 6WIND
