> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, April 22, 2018 9:17 PM > To: Chalupnik, KamilX <kamilx.chalup...@intel.com> > Cc: dev@dpdk.org; Mokhtar, Amr <amr.mokh...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation > > Hi, > > 04/04/2018 16:05, KamilX Chalupnik: > > From: "Chalupnik, KamilX" <kamilx.chalup...@intel.com> > > The above line will appear as the author name in Git. > Please make sure it is the same as the Signed-off-by line. > Usually, we use FirstName LastName, without any comma. > > > > Update the documentation describing Wireless Basband Device: > > - device capabilities updated > > - input/output data buffers description added > > - details about implementation of turbo encode/decode > > operation added > > - images presenting CB/TB processing by turbo encoder/decoder > > added > > > > Signed-off-by: KamilX Chalupnik <kamilx.chalup...@intel.com> > > Is KamilX your name? Or just Kamil? > > > > doc/guides/prog_guide/bbdev.rst | 247 > > +++++++++++++++++++++++-- > - > > doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 bytes > > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 bytes > > 3 files changed, 222 insertions(+), 25 deletions(-) create mode > > 100644 doc/guides/prog_guide/img/turbo_tb_decode.png > > create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png > > No, sorry, you cannot add binary file in this repository. > It is an Open Source project, we provide sources. > For figures, the SVG format is preferred. > > I'm sorry that your Intel colleagues did not warn you. >
Thomas is right. I should have spotted this, sorry about it. Will drop this from next-crypto subtree, so this patch requires a v2. Once it is sent, addressing Thomas' comments, it may be applied. Apologies for the confusion, Pablo
