Hi Ravi, > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 23, 2018 9:06 AM > To: Kumar, Ravi1 <ravi1.ku...@amd.com> > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; dev@dpdk.org; > hemant.agra...@nxp.com > Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 > and sha2 family authentication algo > > 23/04/2018 08:41, Kumar, Ravi1: > > >> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n > > > > > >Why introducing a compile-time option? > > >Can it be a run-time option of the device? > > >We must not add compile-time device option if not well justified. > [...] > > By default, all the crypto operations (cipher + auth) are offloaded to CCP > engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=y, the > auth operations are not offloaded to CCP and rather performed over CPU. We > kept this feature as a compile time option in order to let user decide > whether to > run auth operations on CCP or CPU as some of the auth operations performs > faster on CPU as compared to their performance on CCP. > > No, you do not let the user decide. > The compilation options are for the packager to decide. > The user can rely on pre-compiled packages and use only runtime options. > That's why we forbid compile-time options for such features. >
Could you send a patch to remove this compile-time option and pass it as an option for the vdev? Look at how the crypto scheduler accepts parameters from "rte_vdev_init" or --vdev, in scheduler_pmd.c. Thanks! Pablo
