Hi Xueming, On Fri, Apr 20, 2018 at 07:56:27PM +0800, Xueming Li wrote: > This patch adds new tunnel type for MPLS-in-GRE and MPLS-in-UDP. > > MPLS-in-GRE protocol link: > https://tools.ietf.org/html/rfc4023 > > MPLS-in-UDP protocol link: > https://tools.ietf.org/html/rfc7510 > > Signed-off-by: Xueming Li <xuemi...@mellanox.com> > Acked-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> > --- > lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ > lib/librte_mbuf/rte_mbuf_ptype.h | 34 ++++++++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c > b/lib/librte_mbuf/rte_mbuf_ptype.c > index 49106c7df..10abfe89c 100644 > --- a/lib/librte_mbuf/rte_mbuf_ptype.c > +++ b/lib/librte_mbuf/rte_mbuf_ptype.c > @@ -66,6 +66,8 @@ const char *rte_get_ptype_tunnel_name(uint32_t ptype) > case RTE_PTYPE_TUNNEL_ESP: return "TUNNEL_ESP"; > case RTE_PTYPE_TUNNEL_L2TP: return "TUNNEL_L2TP"; > case RTE_PTYPE_TUNNEL_VXLAN_GPE: return "TUNNEL_VXLAN_GPE"; > + case RTE_PTYPE_TUNNEL_MPLS_IN_UDP: return "TUNNEL_MPLS-IN-UDP"; > + case RTE_PTYPE_TUNNEL_MPLS_IN_GRE: return "TUNNEL_MPLS-IN-GRE"; > default: return "TUNNEL_UNKNOWN"; > } > }
Just one minor comment here: I suggest "TUNNEL_MPLS_IN_UDP" instead of "TUNNEL_MPLS-IN-UDP", in order to be consistent with other strings. Once fixed, feel free to add my ack in the next revision.
