On Fri, Apr 20, 2018 at 08:23:33PM +0800, Xueming Li wrote: > This patch introduced tunnel type identification based on flow rules. > If flows of multiple tunnel types built on same queue, > RTE_PTYPE_TUNNEL_MASK will be returned, user application could use bits > in flow mark as tunnel type identifier. >[...]
There is still the issue about returning this wrong bits in the mbuf. Bit in the mbuf ptypes must only reflect what is present in the mbuf, using RTE_PTYPE_TUNNEL_MASK means all tunnels are present in the packet which is absolutely wrong. This behavior was not announce and breaks API/ABI. It cannot be accepted yet. I'll suggest to add a new RTE_PTYPE_TUNNEL_UNKNOWN which does not break the ABI or don't add such bits in the mbuf. Regards, -- Nélio Laranjeiro 6WIND
