Hi Ferruh, I am not able to apply your patch on next-net/master branch. I am failing to apply it both on latest commit or just before 22-Mar-18 (commit's date).
$ git am dpdk-dev-net-tap-remove-queue-specific-offload-support.patch Applying: net/tap: remove queue specific offload support error: patch failed: drivers/net/tap/rte_eth_tap.c:269 error: drivers/net/tap/rte_eth_tap.c: patch does not apply Patch failed at 0001 net/tap: remove queue specific offload support Please advise. Once this error is fixed I can verify your patch with high priority and send you my feedback. Regards, Ophir > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 18, 2018 1:55 PM > To: Ophir Munk <ophi...@mellanox.com>; Thomas Monjalon > <tho...@monjalon.net>; Pascal Mazon <pascal.ma...@6wind.com>; > Mordechay Haimovsky <mo...@mellanox.com> > Cc: dev@dpdk.org; Shahaf Shuler <shah...@mellanox.com>; Olga Shern > <ol...@mellanox.com> > Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload > support > > On 4/18/2018 10:40 AM, Ophir Munk wrote: > > Hi Ferruh, > > Sorry for the delayed response. > > > > I would like to verify the correctness of this patch by running several > internal tests. > > Is a reply by Monday OK with you? > > Monday can be late to include patch into rc1, any chance to do earlier? > > > > > Regards, > > Ophir > > > >> -----Original Message----- > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Wednesday, April 18, 2018 11:59 AM > >> To: Thomas Monjalon <tho...@monjalon.net>; Pascal Mazon > >> <pascal.ma...@6wind.com>; Mordechay Haimovsky > <mo...@mellanox.com>; > >> Ophir Munk <ophi...@mellanox.com> > >> Cc: dev@dpdk.org; Shahaf Shuler <shah...@mellanox.com>; Olga Shern > >> <ol...@mellanox.com> > >> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific > >> offload support > >> > >> On 4/12/2018 5:23 PM, Ferruh Yigit wrote: > >>> On 4/5/2018 6:49 PM, Thomas Monjalon wrote: > >>>> Pascal, Moti, Ophir, > >>>> please comment. > >>> > >>> Hi Moti, > >>> > >>> Any comment? This has been asked many times now. > >> > >> Hi Moti, Ophir, > >> > >> You have not responded why queue specific offload added in other > thread. > >> And you are not responding to this patch... > >> > >> Hi Pascal, > >> > >> If you also have no objection, this patch is going in. > >> > >> Thanks, > >> ferruh > >> > >> > >>> > >>>> > >>>> 22/03/2018 19:28, Ferruh Yigit: > >>>>> It is not clear if tap PMD supports queue specific offloads, > >>>>> removing the related code. > >>>>> > >>>>> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") > >>>>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") > >>>>> Cc: mo...@mellanox.com > >>>>> > >>>>> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > >>>> > >>>> > >>>> > >>> > >
