On 4/20/2018 2:48 PM, Ferruh Yigit wrote: > On 4/20/2018 2:06 PM, Xueming Li wrote: >> This patch introduce new TX offload flags for device that supports >> IP or UDP tunneled packet L3/L4 checksum and TSO offload. >> It will be used for non-standard tunnels. >> >> The support from the device is for inner and outer checksums on >> IPV4/TCP/UDP and TSO for *any packet with the following format*: >> >> <some headers> / [optional IPv4/IPv6] / [optional TCP/UDP] / <some >> headers> / [optional inner IPv4/IPv6] / [optional TCP/UDP] >> >> For example the following packets can use this feature: >> >> 1. eth / ipv4 / udp / VXLAN / ip / tcp >> 2. eth / ipv4 / GRE / MPLS / ipv4 / udp >> >> Please note that specific tunnel headers that contain payload length, >> sequence id or checksum will not be updated. >> >> Signed-off-by: Xueming Li <xuemi...@mellanox.com> >> Acked-by: Thomas Monjalon <tho...@monjalon.net> > > It is getting messier! [1] > > Hi Thomas, > > Any suggestion on how to manage these rte_flow patches, we are late and they > aren't settle down yet. There are some level of dependency and there are some > uncertainty in some of the dependent patches because of ABI/API process. > > It would be great to get them incremental or have a plan to how to proceed.
Involved parties looks like following: Xueming: Mellanox offloads for tunnel protocols. Adrien: rte_flow improvements for rss? Qi: rte_flow more protocol support? Declan/Awal: TEP, port representor, using rte_flow? Andrew: sfc PMD updates on top of rte_flow changes. Gaetan: devargs, previously devargs dependency mentioned for some of above, not sure that is still the case. I am not clear of latest status above patches and their dependency with eachother, are they in sync or not, it can be nice who know clarifies more. > > > [1] > Previous version in this thread is following patches: > [PATCH v4 1/2] ethdev: add supported hash function check > [PATCH v4 2/2] app/testpmd: new parameter for port config all rss command > > And this set is: > [PATCH v5 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO > [PATCH v5 2/2] app/testpmd: testpmd support Tx generic tunnel offloads > > But there is already v5 send for this set and in other thread there is v7 of > it: > [PATCH v7 0/2] support Tx generic tunnel checksum and TSO > [PATCH v7 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO > [PATCH v7 2/2] app/testpmd: testpmd support Tx generic tunnel offloads > > Most probably you have intended to send another patchset here. >
