We get pointer to mask before we check if fbarray is NULL. Fix
by moving getting mask pointer to until after NULL check.
Coverity issue: 272579
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
---
lib/librte_eal/common/eal_common_fbarray.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_fbarray.c
b/lib/librte_eal/common/eal_common_fbarray.c
index 95a7c8e..c4ed97e 100644
--- a/lib/librte_eal/common/eal_common_fbarray.c
+++ b/lib/librte_eal/common/eal_common_fbarray.c
@@ -349,7 +349,7 @@ find_contig(const struct rte_fbarray *arr, int start, bool
used)
static int
set_used(struct rte_fbarray *arr, int idx, bool used)
{
- struct used_mask *msk = get_used_mask(arr->data, arr->elt_sz, arr->len);
+ struct used_mask *msk;
uint64_t msk_bit = 1ULL << MASK_LEN_TO_MOD(idx);
int msk_idx = MASK_LEN_TO_IDX(idx);
bool already_used;
@@ -359,6 +359,7 @@ set_used(struct rte_fbarray *arr, int idx, bool used)
rte_errno = EINVAL;
return -1;
}
+ msk = get_used_mask(arr->data, arr->elt_sz, arr->len);
ret = 0;
/* prevent array from changing under us */
--
2.7.4
