On 4/17/2018 1:58 PM, Iremonger, Bernard wrote: > Hi Scott, Ajit, > >> -----Original Message----- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ajit Khaparde >> Sent: Monday, April 16, 2018 9:51 PM >> To: dev@dpdk.org >> Cc: Scott Branden <scott.bran...@broadcom.com> >> Subject: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported >> by >> linux kernel >> >> From: Scott Branden <scott.bran...@broadcom.com> >> >> Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h, in previous >> versions it >> is in drivers/pci/pci.h which is private header. >> >> Fix build error when calling pci_is_bridge by not calling/supporting >> pci_is_bridge >> with kernel versions before 3.16. >> >> Signed-off-by: Scott Branden <scott.bran...@broadcom.com> >> Reported-by: Ferruh Yigit <ferruh.yi...@intel.com>
<...> > This patch fixes the compile error seen on the master branch. > However there are the following checkpatch.pl warnings: > > WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version > to which it is merged > #40: FILE: kernel/linux/igb_uio/compat.h:136: > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 16, 0) We need version check, so we can ignore this warning > WARNING: Comparisons should place the constant on the right side of the test > #40: FILE: kernel/linux/igb_uio/compat.h:136: > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 16, 0) Other checks are also like this, I believe better to be compatible. I think we can ignore both warnings for this case. > > total: 0 errors, 2 warnings, 19 lines checked > > Regards, > > Bernard. > >
