[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

[Jasvinder Singh]

The destination string may not have a null termination if
the source string's length is equal to the sizeof(tap->name).

Fix by replacing strncpy with strlcpy that guarantees NULL-termination.

Coverty issue: 272603
Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object")

Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
---
 examples/ip_pipeline/tap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/tap.c b/examples/ip_pipeline/tap.c
index 5b34032..a4e10fa 100644
--- a/examples/ip_pipeline/tap.c
+++ b/examples/ip_pipeline/tap.c
@@ -15,6 +15,8 @@
 #include <string.h>
 #include <unistd.h>
 
+#include <rte_string_fns.h>
+
 #include "tap.h"
 
 #define TAP_DEV                                            "/dev/net/tun"
@@ -85,7 +87,7 @@ tap_create(const char *name)
                return NULL;
 
        /* Node fill in */
-       strncpy(tap->name, name, sizeof(tap->name));
+       strlcpy(tap->name, name, sizeof(tap->name));
        tap->fd = fd;
 
        /* Node add to list */
-- 
2.9.3