Hi Shahaf, On Mon, Apr 16, 2018 at 05:48:19AM +0000, Shahaf Shuler wrote: > Hi Qi, > > Am wondering if we can make the below more generic and not tailored for > specific use cases.
Regarding this, please see my previous answer [1] where I asked Qi to make his changes more focused on the use case at hand when it became clear all this work was targeting OpenFlow. The OF specification [2] defines the behavior associated with each action, for instance when a TTL is 0 or decrementing it would yield 0, the packet must be dropped. Translating this to a generic decrement action for any packet field is not so easy and not convenient. Therefore my opinion is that if OF actions as defined by this specification are supported as hardware capabilities, it makes sense to define dedicated rte_flow actions for each of them (although "OF" should be part of their name for clarity). I'll comment the patch proper in a separate message. [1] http://dpdk.org/ml/archives/dev/2018-April/096857.html [2] https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.0.pdf -- Adrien Mazarguil 6WIND
