On 4/10/2018 4:41 PM, Tiwei Bie wrote: > On Tue, Mar 13, 2018 at 06:05:34PM +0000, Ferruh Yigit wrote: >> Update link status related feature document items and minor updates in >> some link status related functions. >> >> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> >> --- >> doc/guides/nics/features/fm10k.ini | 2 ++ >> doc/guides/nics/features/fm10k_vf.ini | 2 ++ >> doc/guides/nics/features/i40e_vf.ini | 1 + >> doc/guides/nics/features/igb_vf.ini | 1 + >> doc/guides/nics/features/qede.ini | 1 - >> doc/guides/nics/features/qede_vf.ini | 1 - >> doc/guides/nics/features/vhost.ini | 2 -- >> doc/guides/nics/features/virtio_vec.ini | 1 + >> drivers/net/e1000/em_ethdev.c | 2 +- >> drivers/net/ena/ena_ethdev.c | 2 +- >> drivers/net/fm10k/fm10k_ethdev.c | 6 ++---- >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> drivers/net/mlx4/mlx4_ethdev.c | 2 +- >> drivers/net/mlx5/mlx5_ethdev.c | 2 +- >> 15 files changed, 15 insertions(+), 14 deletions(-) > [...] >> diff --git a/doc/guides/nics/features/vhost.ini >> b/doc/guides/nics/features/vhost.ini >> index dffd1f493..31302745a 100644 >> --- a/doc/guides/nics/features/vhost.ini >> +++ b/doc/guides/nics/features/vhost.ini >> @@ -4,8 +4,6 @@ >> ; Refer to default.ini for the full list of available PMD features. >> ; >> [Features] >> -Link status = Y >> -Link status event = Y > > I think vhost PMD supports above features.
I am not able to find where it is supported. Some virtual PMDs report fixed link, with empty link_update() dev_ops, and they are not reported as supporting Link status, as far as I can see vhost also one of them. And for Link status event, PMD needs to support LSC interrupts and should register interrupt handler for it, which I can't find for vhost. I will send next version without updating above one, please point me where these support added if I missed them. > >> Free Tx mbuf on demand = Y >> Queue status event = Y >> Basic stats = Y >> diff --git a/doc/guides/nics/features/virtio_vec.ini >> b/doc/guides/nics/features/virtio_vec.ini >> index c06c860d4..e60fe36ae 100644 >> --- a/doc/guides/nics/features/virtio_vec.ini >> +++ b/doc/guides/nics/features/virtio_vec.ini > > The doc/guides/nics/features/virtio.ini also needs to be updated. Done. > > Thanks for work! > >> @@ -6,6 +6,7 @@ >> [Features] >> Speed capabilities = P >> Link status = Y >> +Link status event = Y >> Rx interrupt = Y >> Queue start/stop = Y >> Promiscuous mode = Y > [...] >
