Hi tonghao: > -----Original Message----- > From: Tonghao Zhang [mailto:[email protected]] > Sent: Monday, April 9, 2018 8:53 AM > To: Zhang, Qi Z <[email protected]> > Cc: Xing, Beilei <[email protected]>; Dai, Wei <[email protected]>; Zhang, > Helin <[email protected]>; Lu, Wenzhuo <[email protected]>; > [email protected] > Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. > > On Wed, Apr 4, 2018 at 10:48 AM, Zhang, Qi Z <[email protected]> wrote: > > > > > >> -----Original Message----- > >> From: dev [mailto:[email protected]] On Behalf Of Tonghao Zhang > >> Sent: Thursday, March 8, 2018 6:57 PM > >> To: Xing, Beilei <[email protected]>; Dai, Wei > >> <[email protected]>; Zhang, Helin <[email protected]>; Lu, > >> Wenzhuo <[email protected]> > >> Cc: [email protected]; Tonghao Zhang <[email protected]> > >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. > >> > >> ping .... > >> > >> On Mon, Feb 5, 2018 at 8:51 AM, <[email protected]> wrote: > >> > From: Tonghao Zhang <[email protected]> > >> > > >> > The patches in the patchset have no dependency. But all of them is > >> > about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration > >> > for ixgbe and ixgbevf, the user and developer can configure it for > >> > their platform. Other patches refine the ixgbe or ixgbevf. > >> > > >> > v2 --> v3: > >> > remove the patch: http://dpdk.org/dev/patchwork/patch/33698 > >> > > >> > Tonghao Zhang (5): > >> > net/ixgbevf: set the inter-interrupt interval for EITR. > >> > net/ixgbe: set the ITR via configuration. > >> > net/ixgbe: write disable to ITR counter. > >> > net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance. > >> > net/ixgbe: remove the unnecessary call rte_intr_enable. > >> > > >> > config/common_base | 2 + > >> > drivers/net/ixgbe/ixgbe_ethdev.c | 79 > >> > +++++++++++++++++++++++----------------- > >> > drivers/net/ixgbe/ixgbe_ethdev.h | 12 ++++++ > >> > drivers/net/ixgbe/ixgbe_rxtx.c | 3 +- > >> > 4 files changed, 61 insertions(+), 35 deletions(-) > >> > > >> > -- > >> > 1.8.3.1 > >> > > > > > Review-by: Qi Zhang <[email protected]> > > > > Minor typo error in patch1 need to be fixed. > Should I sent v4 ?
One more capture on patch 5, https://dpdk.org/dev/patchwork/patch/36433/ Remove rte_intr_enable in interrupt handler may not work with legacy interrupt mode which ixgbe supposed to support. It's better to so some test on that mode if you want patch 5 be applied, or we can just remove patch 5 and I'd like to ack patch 1-4, what do you think? Regards Qi
