On 4/9/2018 2:19 PM, Sunil Kumar Kori wrote: > Signed-off-by: Sunil Kumar Kori <sunil.k...@nxp.com> > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 63 > +++++++++++++++++++++++++++++++++------- > drivers/net/dpaa2/dpaa2_rxtx.c | 32 +++++++-------------
I see more old API related usage after this patch, can you please check if they should be updated: drivers/net/dpaa2/dpaa2_rxtx.c 560: if (dev->data->dev_conf.rxmode.hw_vlan_strip) drivers/net/dpaa2/dpaa2_ethdev.c 106: if (dev->data->dev_conf.rxmode.hw_vlan_filter) 117: if (dev->data->dev_conf.rxmode.hw_vlan_extend) 993: dev->data->dev_conf.rxmode.jumbo_frame = 1; 995: dev->data->dev_conf.rxmode.jumbo_frame = 0; <...> > + dev_info->default_rxconf.rx_drop_en = true; This change is not related to the offload API I believe, if this is required what do you think to split into another patch? <...>