On Thu, 05 Apr 2018 22:52:31 +0200 Thomas Monjalon <tho...@monjalon.net> wrote:
> Hi Stephen, > > Good to see there is a good progress. > > This patch should add an entry in the release notes. > But I guess it is not ready for 18.05? > > > 05/04/2018 21:13, Stephen Hemminger: > > +# > > +# Compile native PMD for Hyper-V/Azure > > +# > > +CONFIG_RTE_LIBRTE_NETVSC_PMD=n > > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_RX=n > > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_TX=n > > +CONFIG_RTE_LIBRTE_NETVSC_DEBUG_DUMP=n > > Please switch to the new dynamic logging. It does use dynamic logging for the normal driver logs. For debug the dump code is a config option (same as other current drivers). > > > [...] > > +the Data Plane Development Kit (DPDK), we provide a Netwwork Virtual > > typo: Netwwork > > > > +The following prerequisites apply: > > + > > +* Linux kernel uio_hv_generic driver that supports subchannels. This > > should be present in 4.17 or later. > > The DPDK policy is to wait for prerequisite be available for merging. Does linux-next count? > > > > --- a/drivers/net/Makefile > > +++ b/drivers/net/Makefile > > @@ -46,6 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx > > DIRS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) += vdev_netvsc > > DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio > > DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 > > +DIRS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += netvsc > > Please keep the alphabetical order. Ok