On Thu, Apr 05, 2018 at 12:10:13PM +0200, Jens Freimann wrote: > Signed-off-by: Jens Freimann <jfreim...@redhat.com> > --- > drivers/net/virtio/virtio_ring.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ring.h > b/drivers/net/virtio/virtio_ring.h > index 1bd7ba98e..54a11d2a9 100644 > --- a/drivers/net/virtio/virtio_ring.h > +++ b/drivers/net/virtio/virtio_ring.h > @@ -16,7 +16,10 @@ > #define VRING_DESC_F_WRITE 2 > /* This means the buffer contains a list of buffer descriptors. */ > #define VRING_DESC_F_INDIRECT 4 > -
Why remove this empty line? VRING_DESC_F_* and VRING_USED_F_NO_NOTIFY/VRING_AVAIL_F_NO_INTERRUPT are unrelated. I think we still need this to make the code more readable. > +/* This flag means the descriptor was made available by the driver */ > +#define VRING_DESC_F_AVAIL (1ULL << 7) > +/* This flag means the descriptor was used by the device */ > +#define VRING_DESC_F_USED (1ULL << 15) > /* The Host uses this in used->flags to advise the Guest: don't kick me > * when you add a buffer. It's unreliable, so it's simply an > * optimization. Guest will still kick if it's out of buffers. */ > -- > 2.14.3 >
