Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio functions

[Wang, Xiao W]

Yes, it's private. We could do that if really needed.

BRs,
Xiao
> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, April 5, 2018 6:23 PM
> To: Wang, Xiao W <xiao.w.w...@intel.com>
> Cc: Hemant Agrawal <hemant.agra...@nxp.com>; dev@dpdk.org; Burakov,
> Anatoly <anatoly.bura...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal/vfio: export internal vfio 
> functions
> 
> 05/04/2018 11:03, Wang, Xiao W:
> 
> > > +int rte_vfio_get_group_num(const char *sysfs_base, const char
> *dev_addr,
> > > +                    int *iommu_group_num);
> > > +int rte_vfio_get_container_fd(void);
> > > +int rte_vfio_get_group_fd(int iommu_group_num);
> >
> > Considering the "group_no" field defined in eal_vfio.h, will
> "iommu_group_num" cause inconsistency
> > In naming?
> 
> I asked to change the function name to "num" because it is more meaningful.
> "group_no" field is private? Can it be renamed?
>