On Wed, Apr 04, 2018 at 02:27:25PM +0300, Arnon Warshavsky wrote:
> Signed-off-by: Arnon Warshavsky <ar...@qwilt.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++---
> drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++---
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 784b96d..37a5727 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops = {
> RTE_CACHE_LINE_SIZE,
> rte_socket_id());
>
> - if (cryptodev->data->dev_private == NULL)
> - rte_panic("Cannot allocate memzone for private "
> - "device data");
> + if (cryptodev->data->dev_private == NULL) {
> + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for "
> + "private device data", __func__);
> + return -1;
> + }
> }
This is the right change to make, but can you please avoid wrapping literal
strings across lines. It means that the error message cannot be grepped.
Just put the __func__ on the second line.
Checkpatch and similar tools should ignore long lines if the long line is
simply caused by a literal string.
/Bruce
