03/04/2018 08:55, Shreyansh Jain: > On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: > > Some comments are not relevant in a config which only overrides > > the default config. > > > > The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled > > by default so it can be removed from this file. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > --- > > config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- > > 1 file changed, 7 deletions(-) > > I think DEBUG_DRIVER should exist in local config so that a developer > can easily toggle it without modifying the common_base, which should > serves as repository rather than toggle.
No, the file to be modified is .config in the build directory, not the default config. > I do see the problem that having an option in common_base and then > having it again in local config without overriding (=n) - is non-intuitive. > > But, I still feel it is easier to control changes in local config - > (make T=<local config>) is easily visible. It is not a local config file. The local config is .config.
