Hi Jay, > -----Original Message----- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Zhang, Roy > Fan <roy.fan.zh...@intel.com>; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin <xin.z...@intel.com>; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.com; > longpe...@huawei.com; jianjay.z...@huawei.com > Subject: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental > functions > > Since there does not have the common virtio library, we have to put these > files here. They are basically the same with virtio net related files with > some > minor changes. > > Signed-off-by: Jay Zhou <jianjay.z...@huawei.com> > --- > config/common_base | 20 ++ > drivers/crypto/virtio/virtio_logs.h | 47 ++++ > drivers/crypto/virtio/virtio_pci.c | 460 > ++++++++++++++++++++++++++++++++++++ > drivers/crypto/virtio/virtio_pci.h | 253 ++++++++++++++++++++ > drivers/crypto/virtio/virtio_ring.h | 137 +++++++++++ > drivers/crypto/virtio/virtqueue.c | 43 ++++ > drivers/crypto/virtio/virtqueue.h | 176 ++++++++++++++ > 7 files changed, 1136 insertions(+) > create mode 100644 drivers/crypto/virtio/virtio_logs.h > create mode 100644 drivers/crypto/virtio/virtio_pci.c > create mode 100644 drivers/crypto/virtio/virtio_pci.h > create mode 100644 drivers/crypto/virtio/virtio_ring.h > create mode 100644 drivers/crypto/virtio/virtqueue.c create mode > 100644 drivers/crypto/virtio/virtqueue.h > > diff --git a/config/common_base b/config/common_base index > ad03cf4..19d0cdd 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -482,6 +482,26 @@ > CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=n > CONFIG_RTE_QAT_PMD_MAX_NB_SESSIONS=2048 > > # > +# Compile PMD for virtio crypto devices # > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_INIT=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_SESSION=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_TX=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_RX=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DRIVER=n > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DUMP=n
Could you remove these DEBUG options? I see that they are used only for enabling logging. For that, we are using now dynamic logging. Take a look at the following commit, as an example: 510ac6f4f030 ("event/sw: support dynamic logging") Pablo